feat(CategoryTheory): kan extensions from isos#41484
Open
FernandoChu wants to merge 2 commits into
Open
Conversation
FernandoChu
added
t-category-theory
github-actions
Bot
added
the
large-import
PR summary aa1a23fc0dImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.CategoryTheory.Bicategory.Kan.IsKan | 449 | 465 | +16 (+3.56%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.CategoryTheory.Bicategory.Kan.Adjunction Mathlib.CategoryTheory.Bicategory.Kan.HasKan |
4 |
Mathlib.CategoryTheory.Bicategory.Kan.IsKan |
16 |
Declarations diff (regex)
+ IsAbsKan
+ fac
+ hom_ext
+ isKan
+ mk
+ ofIsoAbsKan
+ ofIsoKan
+ uniqueUpToIso
+ uniqueUpToIso_hom_left
+ uniqueUpToIso_inv_left
+ whisker
+ whiskerHom
+ whiskerIdCancel
+ whiskerIso
+ whiskerOfCommute
+ whiskerOfCompIdIsoSelf
+ whisker_counit
+ whisker_extension
+ whiskering
++ desc
++ ofCompId
++ ofIso_counit
++ ofIso_extension
++ ofIso_lift
++ ofIso_unit
++++ mapIso
++++ whiskerOfIso
++++++++++++ ofIso
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
aa1a23f).
- +62 new declarations
- −0 removed declarations
+CategoryTheory.Bicategory.LeftExtension.IsAbsKan.ofIso
+CategoryTheory.Bicategory.LeftExtension.IsKan.ofIso
+CategoryTheory.Bicategory.LeftExtension.mapIso
+CategoryTheory.Bicategory.LeftExtension.ofIso
+CategoryTheory.Bicategory.LeftExtension.ofIso_extension
+CategoryTheory.Bicategory.LeftExtension.ofIso_unit
+CategoryTheory.Bicategory.LeftExtension.whiskerOfIso
+CategoryTheory.Bicategory.LeftLift.IsAbsKan.ofIso
+CategoryTheory.Bicategory.LeftLift.IsKan.ofIso
+CategoryTheory.Bicategory.LeftLift.mapIso
+CategoryTheory.Bicategory.LeftLift.ofIso
+CategoryTheory.Bicategory.LeftLift.ofIso_lift
+CategoryTheory.Bicategory.LeftLift.ofIso_unit
+CategoryTheory.Bicategory.LeftLift.whiskerOfIso
+CategoryTheory.Bicategory.RightExtension.IsAbsKan
+CategoryTheory.Bicategory.RightExtension.IsAbsKan.desc
+CategoryTheory.Bicategory.RightExtension.IsAbsKan.isKan
+CategoryTheory.Bicategory.RightExtension.IsAbsKan.ofIso
+CategoryTheory.Bicategory.RightExtension.IsAbsKan.ofIsoAbsKan
+CategoryTheory.Bicategory.RightExtension.IsKan.desc
+CategoryTheory.Bicategory.RightExtension.IsKan.fac
+CategoryTheory.Bicategory.RightExtension.IsKan.fac_assoc
+CategoryTheory.Bicategory.RightExtension.IsKan.hom_ext
+CategoryTheory.Bicategory.RightExtension.IsKan.mk
+CategoryTheory.Bicategory.RightExtension.IsKan.ofCompId
+CategoryTheory.Bicategory.RightExtension.IsKan.ofIso
+CategoryTheory.Bicategory.RightExtension.IsKan.ofIsoKan
+CategoryTheory.Bicategory.RightExtension.IsKan.uniqueUpToIso
+CategoryTheory.Bicategory.RightExtension.IsKan.uniqueUpToIso_hom_left
+CategoryTheory.Bicategory.RightExtension.IsKan.uniqueUpToIso_inv_left
+CategoryTheory.Bicategory.RightExtension.IsKan.whiskerOfCommute
+CategoryTheory.Bicategory.RightExtension.homMk.congr_simp
+CategoryTheory.Bicategory.RightExtension.mapIso
+CategoryTheory.Bicategory.RightExtension.ofCompId
+CategoryTheory.Bicategory.RightExtension.ofCompId_hom
+CategoryTheory.Bicategory.RightExtension.ofCompId_left
+CategoryTheory.Bicategory.RightExtension.ofCompId_right_as
+CategoryTheory.Bicategory.RightExtension.ofIso
+CategoryTheory.Bicategory.RightExtension.ofIso_counit
+CategoryTheory.Bicategory.RightExtension.ofIso_extension
+CategoryTheory.Bicategory.RightExtension.whisker
+CategoryTheory.Bicategory.RightExtension.whiskerHom
+CategoryTheory.Bicategory.RightExtension.whiskerHom_left
+CategoryTheory.Bicategory.RightExtension.whiskerIdCancel
+CategoryTheory.Bicategory.RightExtension.whiskerIdCancel_left
+CategoryTheory.Bicategory.RightExtension.whiskerIso
+CategoryTheory.Bicategory.RightExtension.whiskerOfCompIdIsoSelf
+CategoryTheory.Bicategory.RightExtension.whiskerOfCompIdIsoSelf_hom_left
+CategoryTheory.Bicategory.RightExtension.whiskerOfCompIdIsoSelf_inv_left
+CategoryTheory.Bicategory.RightExtension.whiskerOfIso
+CategoryTheory.Bicategory.RightExtension.whisker_counit
+CategoryTheory.Bicategory.RightExtension.whisker_extension
+CategoryTheory.Bicategory.RightExtension.whiskering
+CategoryTheory.Bicategory.RightExtension.whiskering_map
+CategoryTheory.Bicategory.RightExtension.whiskering_obj
+CategoryTheory.Bicategory.RightLift.IsAbsKan.ofIso
+CategoryTheory.Bicategory.RightLift.IsKan.ofIso
+CategoryTheory.Bicategory.RightLift.mapIso
+CategoryTheory.Bicategory.RightLift.ofIso
+CategoryTheory.Bicategory.RightLift.ofIso_counit
+CategoryTheory.Bicategory.RightLift.ofIso_lift
+CategoryTheory.Bicategory.RightLift.whiskerOfIsoIncrease in strong tech debt: (relative, absolute) = (1.89, 0.00)
| Current number | Change | Type (strong) |
|---|---|---|
| 4516 | 1 | backward.defeqAttrib.useBackward |
| 5661 | 3 | backward.isDefEq.respectTransparency |
Current commit aa1a23fc0d
Reference commit f0630767e5
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
|
Can you please elaborate on the AI use for this PR? You have labelled it already, but right now we cannot tell if this is a fully autonomous agent or asking an LLM to review for typos. |
Collaborator
Author
|
Hi @grunweg. I've added a description of the AI use. Is there any place containing what the best practices for disclosure are? I personally just always do this loop of AI generation > fixing/finetuning > repeat. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR constructs lifts out of isomorphisms of 1-cells, and shows that being (abs) Kan is preserved by this. This is done for all four notions of left/right lifts/extensions.
This is needed for the oo-cosmos project.
AI disclosure. Claude was used in defining the API for the left extension case. After manually fixing its bad proofs/definitions/docstrings, Claude was later asked to replicate this for the other three cases, which I again finetuned.