Skip to content

feat(LinearAlgebra/Dimension/Free): division version of tower law#41488

Open
artie2000 wants to merge 3 commits into
leanprover-community:masterfrom
artie2000:finrank_div
Open

feat(LinearAlgebra/Dimension/Free): division version of tower law#41488
artie2000 wants to merge 3 commits into
leanprover-community:masterfrom
artie2000:finrank_div

Conversation

@artie2000

@artie2000 artie2000 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Split from #37959


Open in Gitpod

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PR summary 9813ba563c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ Module.finrank_div_finrank_cancel_left
+ Module.finrank_div_finrank_cancel_right
+ Module.finrank_left_dvd_finrank
+ Module.finrank_right_dvd_finrank

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 9813ba563c
Reference commit ed0d70fdcd

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Jul 8, 2026
Comment thread Mathlib/LinearAlgebra/Dimension/Free.lean Outdated
@artie2000 artie2000 added the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 8, 2026
Comment thread Mathlib/LinearAlgebra/Dimension/Free.lean Outdated
@artie2000 artie2000 removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 12, 2026
@artie2000

Copy link
Copy Markdown
Collaborator Author

I asked about the dvd names on Zulip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants