Skip to content

feat(NumberTheory/Bernoulli): add bernoulli'_five and bernoulli'_six#41491

Closed
qdiazblanco wants to merge 1 commit into
leanprover-community:masterfrom
qdiazblanco:Bernoulli-LogosWS
Closed

feat(NumberTheory/Bernoulli): add bernoulli'_five and bernoulli'_six#41491
qdiazblanco wants to merge 1 commit into
leanprover-community:masterfrom
qdiazblanco:Bernoulli-LogosWS

Conversation

@qdiazblanco

Copy link
Copy Markdown

Add bernoulli'_five and bernoulli'_six as simp lemmas, continuing the
existing sequence of explicit values bernoulli'_zero through
bernoulli'_four. In particular this records bernoulli' 5 = 0 and
bernoulli' 6 = 1 / 42.

These results are upstreamed from the FLT project
(ImperialCollegeLondon/FLT#1069, by William Coram
and Samuel Yin, written with the assistance of Claude and
cleaned up by Codex and then by Pepa Montero). I have done some further changes to fit Mathlib conventions.


Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PR summary 6366d52008

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ bernoulli'_five
+ bernoulli'_six

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 6366d52).

  • +2 new declarations
  • −0 removed declarations
+bernoulli'_five
+bernoulli'_six

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 6366d52008
Reference commit ed0d70fdcd

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to add more computations of small Bernoulli numbers? Instead we should make it easier to compute them whenever needed. See https://leanprover.zulipchat.com/#narrow/channel/116395-maths/topic/Fast.20computation.20of.20Bernoulli.20numbers/with/590406943 for some ideas.

maintainer merge?

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 8, 2026
@qdiazblanco qdiazblanco closed this Jul 8, 2026
@qdiazblanco qdiazblanco deleted the Bernoulli-LogosWS branch July 8, 2026 14:47
@b-mehta

b-mehta commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

I am working on a metaprogram to compute these (which outperforms the methods in that thread), keep an eye out for a PR about this, or feel free to DM me if you need something sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants