Skip to content

[Merged by Bors] - perf: make valuation unexposed#41492

Closed
smmercuri wants to merge 1 commit into
leanprover-community:masterfrom
smmercuri:no_expose_valuation
Closed

[Merged by Bors] - perf: make valuation unexposed#41492
smmercuri wants to merge 1 commit into
leanprover-community:masterfrom
smmercuri:no_expose_valuation

Conversation

@smmercuri

Copy link
Copy Markdown
Collaborator

Open in Gitpod

@smmercuri smmercuri added the WIP Work in progress label Jul 8, 2026
@smmercuri

Copy link
Copy Markdown
Collaborator Author

!radar

@leanprover-radar

leanprover-radar commented Jul 8, 2026

Copy link
Copy Markdown

Benchmark results for 2d375ad against 6f60478 are in. No significant results found. @smmercuri

  • build//instructions: -283.3G (-0.18%)

Medium changes (1✅)

1 hidden

Small changes (1✅)

  • build/module/Mathlib.RingTheory.LaurentSeries//instructions: -7.2G (-4.65%)

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PR summary 2d375ad2c3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 2d375ad).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 2d375ad2c3
Reference commit 6f60478685

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Jul 8, 2026
@smmercuri smmercuri removed the WIP Work in progress label Jul 8, 2026

@YaelDillies YaelDillies left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 8, 2026

@TwoFX TwoFX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 8, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 8, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 8, 2026
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 8, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title perf: make valuation unexposed [Merged by Bors] - perf: make valuation unexposed Jul 8, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 8, 2026
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants