Skip to content

[Merged by Bors] - perf: make valuation unexposed #41492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smmercuri wants to merge 1 commit into from
Closed

[Merged by Bors] - perf: make valuation unexposed #41492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Mathlib/RingTheory/DedekindDomain/AdicValuation.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,15 +325,15 @@ theorem intValuation_eq_one_iff {v : HeightOneSpectrum R} {x : R} :
variable (K) in
/-- The `v`-adic valuation of `x : K` is the valuation of `r` divided by the valuation of `s`,
where `r` and `s` are chosen so that `x = r/s`. -/
@[no_expose]
def valuation (v : HeightOneSpectrum R) : Valuation K ℤᵐ⁰ :=
v.intValuation.extendToLocalization
(fun r hr => Set.mem_compl <| v.intValuation_ne_zero' ⟨r, hr⟩) K

theorem valuation_def (x : K) :
v.valuation K x =
v.intValuation.extendToLocalization
(fun r hr => Set.mem_compl (v.intValuation_ne_zero' ⟨r, hr⟩)) K x :=
rfl
(fun r hr => Set.mem_compl (v.intValuation_ne_zero' ⟨r, hr⟩)) K x := by rw [valuation]

/--
The `v`-adic valuation of `r / s : K` is the valuation of `r` divided by the valuation of `s`. -/
Expand Down
2 changes: 1 addition & 1 deletion Mathlib/RingTheory/DedekindDomain/SelmerGroup.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def valuationOfNeZeroToFun (x : Kˣ) : Multiplicative ℤ :=
theorem valuationOfNeZeroToFun_eq (x : Kˣ) :
(v.valuationOfNeZeroToFun x : ℤᵐ⁰) = v.valuation K x := by
classical
rw [show v.valuation K x = _ * _ by rfl]
rw [show v.valuation K x = _ * _ by rw [valuation_def]; rfl]
rw [Units.val_inv_eq_inv_val]
change _ = ite _ _ _ * (ite _ _ _)⁻¹
simp_rw [IsLocalization.toLocalizationMap_sec, SubmonoidClass.coe_subtype,
Expand Down
Loading