Skip to content

[Merged by Bors] - chore: remove some redundant classical #41497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixpernegger wants to merge 3 commits into from
Closed

[Merged by Bors] - chore: remove some redundant classical #41497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7897e8c
chore: remove some redundant `classical`
felixpernegger Jul 8, 2026
53aca59
one more
felixpernegger Jul 8, 2026
e3867a6
move to proof
felixpernegger Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Mathlib/Combinatorics/SimpleGraph/Clique.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,6 @@ lemma CliqueFree.mem_of_sup_edge_isNClique {x y : α} {t : Finset α} {n : ℕ}
have ht : (t : Set α) \ {x} = t := sdiff_eq_left.mpr <| Set.disjoint_singleton_right.mpr hf
exact h t ⟨ht ▸ hc.1.sdiff_of_sup_edge, hc.2⟩

open scoped Classical in
/-- Adding an edge increases the clique number by at most one. -/
protected theorem CliqueFree.sup_edge (h : G.CliqueFree n) (v w : α) :
(G ⊔ edge v w).CliqueFree (n + 1) := by
Expand Down
1 change: 0 additions & 1 deletion Mathlib/FieldTheory/PurelyInseparable/Exponent.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ is the smallest natural number `e` such that `a ^ ringExpChar K ^ e ∈ K`. -/
noncomputable def elemExponent (a : L) : ℕ :=
Nat.find <| minpoly_eq_X_pow_sub_C K (ringExpChar K) a

open scoped Classical in
variable {K} in
theorem elemExponent_eq_zero_of_mem_range {a : L} (h : a ∈ (algebraMap K L).range) :
elemExponent K a = 0 := by
Expand Down
1 change: 0 additions & 1 deletion Mathlib/NumberTheory/NumberField/CanonicalEmbedding/NormLeOne.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,6 @@ theorem logMap_expMapBasis (x : realSpace K) :
logMap (mixedSpaceOfRealSpace (expMapBasis x)) ∈
ZSpan.fundamentalDomain ((basisUnitLattice K).ofZLatticeBasis ℝ (unitLattice K))
↔ ∀ w, w ≠ w₀ → x w ∈ Set.Ico 0 1 := by
classical
Comment thread
felixpernegger marked this conversation as resolved.
simp_rw [ZSpan.mem_fundamentalDomain, equivFinRank.forall_congr_left, Subtype.forall]
refine forall₂_congr fun w hw ↦ ?_
rw [expMapBasis_apply'', map_smul, logMap_real_smul (norm_expMapBasis_ne_zero _)
Expand Down
3 changes: 1 addition & 2 deletions Mathlib/RingTheory/DedekindDomain/Different.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ open scoped Classical in
lemma traceDual_top' :
(⊤ : Submodule B L)ᵛ =
if ((LinearMap.range (Algebra.trace K L)).restrictScalars A ≤ 1) then ⊤ else ⊥ := by
classical

@grunweg grunweg Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, please remove the open scoped Classical in instead.

@felixpernegger felixpernegger Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check each of them before the PR

@grunweg grunweg Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do this instead?

/-- The dual of a non-zero fractional ideal is the dual of the submodule under the trace form. -/
noncomputable
def dual (I : FractionalIdeal B⁰ L) : FractionalIdeal B⁰ L :=
  open scoped Classical in

@grunweg grunweg Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The point is that the statement then does not rely on any classical decidability instances, although this might be quite minor here.)

@felixpernegger felixpernegger Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats another line. I think the script missed something (or I when i went over it), but whatever

split_ifs with h
· rw [_root_.eq_top_iff]
exact fun _ _ _ _ ↦ h ⟨_, rfl⟩
Expand Down Expand Up @@ -224,11 +223,11 @@ variable [IsDomain A] [IsFractionRing B L] [Nontrivial B] [NoZeroDivisors B]

namespace FractionalIdeal

open scoped Classical in
/-- The dual of a non-zero fractional ideal is the dual of the submodule under the trace form. -/
noncomputable
def dual (I : FractionalIdeal B⁰ L) :
FractionalIdeal B⁰ L :=
open scoped Classical in
if hI : I = 0 then 0 else
⟨Iᵛ, by
classical
Comment on lines +230 to 233

@felixpernegger felixpernegger Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI here we really need both

Expand Down
1 change: 0 additions & 1 deletion Mathlib/RingTheory/Extension/Presentation/Submersive.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ variable [Fintype σ] [Fintype σ']
open scoped Classical in
private lemma jacobiMatrix_comp_inl_inr (i : σ') (j : σ) :
(Q.comp P).jacobiMatrix (Sum.inl i) (Sum.inr j) = 0 := by
classical
Comment thread
felixpernegger marked this conversation as resolved.
rw [jacobiMatrix_apply]
refine MvPolynomial.pderiv_eq_zero_of_notMem_vars (fun hmem ↦ ?_)
apply MvPolynomial.vars_rename at hmem
Expand Down
Loading