Skip to content

feat(NumberTheory): add bernoulli'_five, bernoulli'_six and riemannZeta_six#41499

Open
qdiazblanco wants to merge 2 commits into
leanprover-community:masterfrom
qdiazblanco:logos-ws-bernoulli-zeta-values
Open

feat(NumberTheory): add bernoulli'_five, bernoulli'_six and riemannZeta_six#41499
qdiazblanco wants to merge 2 commits into
leanprover-community:masterfrom
qdiazblanco:logos-ws-bernoulli-zeta-values

Conversation

@qdiazblanco

@qdiazblanco qdiazblanco commented Jul 8, 2026

Copy link
Copy Markdown

Add bernoulli'_five and bernoulli'_six as simp lemmas, continuing the
existing sequence of explicit values bernoulli'_zero through
bernoulli'_four, and use the latter to prove riemannZeta 6 = π ^ 6 / 945.

Along the way, golf the proofs of bernoulli'_two, bernoulli'_three and
bernoulli'_four .

These results are upstreamed from the FLT project (ImperialCollegeLondon/FLT#1069).

Co-authored-by: William Coram
Co-authored-by: Samuel Yin
Co-authored-by: Pepa Montero
Co-authored-by: Archie Browne


Original PR by William Coram and Samuel Yin, written with the assistance of Claude and
cleaned up by Codex and then by Pepa Montero).

I have done some further changes to fit Mathlib conventions and Claude was also used to help shorten the
proof of riemannZeta_six with an idea by Archie Browne.

Open in Gitpod

Also golf the proofs of bernoulli'_two, bernoulli'_three and bernoulli'_four, removing the  workaround.
@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@grunweg grunweg added FLT part of the ongoing formalization of Fermat's Last Theorem LLM-generated PRs with substantial input from LLMs - review accordingly labels Jul 8, 2026
@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PR summary 886441ec86

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ bernoulli'_five
+ bernoulli'_six
+ riemannZeta_six

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 886441e).

  • +3 new declarations
  • −0 removed declarations
+bernoulli'_five
+bernoulli'_six
+riemannZeta_six

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 886441ec86
Reference commit ed0d70fdcd

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg

grunweg commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR! Let me ask the same question as Yael on the other PR: do we want to have these lemmas, or should we invest in a better tactic instead?

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Jul 8, 2026
@qdiazblanco

Copy link
Copy Markdown
Author

Thanks for the PR! Let me ask the same question as Yael on the other PR: do we want to have these lemmas, or should we invest in a better tactic instead?

I think you're both right and Bhavik said he's working on it in a comment on the PR I closed yesterday:

I am working on a metaprogram to compute these (which outperforms the methods in that thread), keep an eye out for a PR about this, or feel free to DM me if you need something sooner.

That's certainly the better option, we just need this values for the FLT. So maybe for now it is useful having them?

@grunweg

grunweg commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

If Bhavik is indeed working on them now, I'd rather wait for Bhavik for a moment. The code is already fine in FLT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. FLT part of the ongoing formalization of Fermat's Last Theorem LLM-generated PRs with substantial input from LLMs - review accordingly new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants