Skip to content

[Merged by Bors] - chore(Geometry/Manifold/Submersion): reword 'project intentions' phrase#41500

Closed
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:reword-submersions-intentions
Closed

[Merged by Bors] - chore(Geometry/Manifold/Submersion): reword 'project intentions' phrase#41500
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:reword-submersions-intentions

Conversation

@grunweg

@grunweg grunweg commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

As suggested privately by kim-em; the current phrasing reads nicer and conveys what the original phrasing meant to say.


Open in Gitpod

As suggested privately by ; the current phrasing reads nicer and conveys
what the original phrasing meant to say.
@grunweg grunweg requested a review from kim-em July 8, 2026 15:01
@github-actions github-actions Bot added the t-differential-geometry Manifolds etc label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PR summary 5de7ba01c6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 5de7ba0).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 5de7ba01c6
Reference commit ae588ec23e

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kim-em

kim-em commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 9, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 9, 2026
…se (#41500)

As suggested privately by `kim-em`; the current phrasing reads nicer and conveys what the original phrasing meant to say.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 9, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(Geometry/Manifold/Submersion): reword 'project intentions' phrase [Merged by Bors] - chore(Geometry/Manifold/Submersion): reword 'project intentions' phrase Jul 9, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 9, 2026
@grunweg grunweg deleted the reword-submersions-intentions branch July 10, 2026 10:13
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Jul 11, 2026
…se (leanprover-community#41500)

As suggested privately by `kim-em`; the current phrasing reads nicer and conveys what the original phrasing meant to say.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants