Skip to content

feat(GRewrite): support strict rewriting in >/#41503

Open
JovanGerb wants to merge 2 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-grw-strict_ge
Open

feat(GRewrite): support strict rewriting in >/#41503
JovanGerb wants to merge 2 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-grw-strict_ge

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

This PR adds gcongr strict tags in order to support strict rewriting in />. Previously this only worked in /<.


Open in Gitpod

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PR summary 01c2a28e28

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ ge_imp_gt_of_lt

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 01c2a28).

  • +2 new declarations
  • −0 removed declarations
+ge_imp_gt_of_lt
+ge_imp_gt_of_lt'

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 01c2a28e28
Reference commit 87a6eccfb8

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant