feat: add formula for the j-invariant of an elliptic curve#41504
feat: add formula for the j-invariant of an elliptic curve#41504Paul-Lez wants to merge 3 commits into
j-invariant of an elliptic curve#41504Conversation
PR summary ce9a86929fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| lemma j_eq_zero_iff [IsReduced R] : W.j = 0 ↔ W.c₄ = 0 := by | ||
| rw [j_eq_zero_iff', pow_eq_zero_iff three_ne_zero] | ||
|
|
||
| theorem j_eq {K : Type*} [Field K] (W : WeierstrassCurve K) [W.IsElliptic] : |
There was a problem hiding this comment.
Make this a lemma. Surely K and W are already defined elsewhere. Can you also move this up to right below the definition?
There was a problem hiding this comment.
K and W are defined elsewhere (R instead of K, but as a CommRing so can't be used directly).
There was a problem hiding this comment.
Ah gotcha, this is one of the few stupid files where we don't have W' for R and W for K...
This doesn't seem to be in Mathlib yet (?).