Skip to content

[Merged by Bors] - feat(CategoryTheory/Sites/Over): add Presieve.overEquiv#41510

Closed
tb65536 wants to merge 10 commits into
leanprover-community:masterfrom
tb65536:tb_sieves
Closed

[Merged by Bors] - feat(CategoryTheory/Sites/Over): add Presieve.overEquiv#41510
tb65536 wants to merge 10 commits into
leanprover-community:masterfrom
tb65536:tb_sieves

Conversation

@tb65536

@tb65536 tb65536 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This PR adds Presieve.overEquiv, the presieve version of the existing Sieve.overEquiv. I also upgraded these equivs to order isomorphisms, and fixed some defeq abuse at the same time.

Partial help from Claude on a couple of the proofs, all code was ultimately written and golfed by me.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-category-theory Category theory labels Jul 8, 2026
@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

PR summary 88ef7429f9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ Presieve.map_le_functorPushforward
+ arrows_mono
+ functorPullback_functorPushforward_overForget
+ functorPullback_map_overForget
+ functorPushforward_functorPullback_overForget
+ functorPushforward_overForget_arrows
+ map_functorPullback_overForget
++- overEquiv
- Presieve.map_functorPullback_overForget

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 88ef742).

  • +11 new declarations
  • −0 removed declarations
+CategoryTheory.Presieve.functorPullback_map_overForget
+CategoryTheory.Presieve.map_le_functorPushforward
+CategoryTheory.Presieve.overEquiv
+CategoryTheory.Presieve.overEquiv_apply
+CategoryTheory.Presieve.overEquiv_symm_apply
+CategoryTheory.Sieve.arrows_mono
+CategoryTheory.Sieve.functorPullback_functorPushforward_overForget
+CategoryTheory.Sieve.functorPushforward_functorPullback_overForget
+CategoryTheory.Sieve.functorPushforward_overForget_arrows
+CategoryTheory.Sieve.overEquiv_apply
+CategoryTheory.Sieve.overEquiv_symm_apply

Decrease in strong tech debt: (relative, absolute) = (1.45, 0.00)
Current number Change Type (strong)
4514 -1 backward.defeqAttrib.useBackward
5624 -2 backward.isDefEq.respectTransparency
No changes to weak technical debt.

Current commit 88ef7429f9
Reference commit ae861491c1

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@tb65536 tb65536 requested a review from erdOne July 8, 2026 18:22
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 8, 2026
Comment thread Mathlib/CategoryTheory/Sites/Sieves.lean
@erdOne

erdOne commented Jul 9, 2026

Copy link
Copy Markdown
Member

Thanks!
maintainer merge

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by erdOne.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 9, 2026
@joelriou

joelriou commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 9, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 9, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 9, 2026
This PR adds `Presieve.overEquiv`, the presieve version of the existing `Sieve.overEquiv`. I also upgraded these equivs to order isomorphisms, and fixed some defeq abuse at the same time.

Partial help from Claude on a couple of the proofs, all code was ultimately written and golfed by me.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 9, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title feat(CategoryTheory/Sites/Over): add Presieve.overEquiv [Merged by Bors] - feat(CategoryTheory/Sites/Over): add Presieve.overEquiv Jul 9, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 9, 2026
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Jul 11, 2026
…-community#41510)

This PR adds `Presieve.overEquiv`, the presieve version of the existing `Sieve.overEquiv`. I also upgraded these equivs to order isomorphisms, and fixed some defeq abuse at the same time.

Partial help from Claude on a couple of the proofs, all code was ultimately written and golfed by me.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-category-theory Category theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants