[Merged by Bors] - chore: fix some ENat-related instances of backward.isDefEq.respectTransparency#41515
Closed
vlad902 wants to merge 2 commits into
Closed
[Merged by Bors] - chore: fix some ENat-related instances of backward.isDefEq.respectTransparency#41515vlad902 wants to merge 2 commits into
backward.isDefEq.respectTransparency#41515vlad902 wants to merge 2 commits into
Conversation
PR summary a9cf1d2b14Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| 5622 | -5 | backward.isDefEq.respectTransparency |
Current commit a9cf1d2b14
Reference commit 1c3e8f34a8
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
vlad902
commented
Jul 9, 2026
| | ⊤, _ => exact tendsto_nhds_top_mono' continuousAt_fst fun p ↦ le_add_right le_rfl | ||
| | (a : ℕ), ⊤ => exact tendsto_nhds_top_mono' continuousAt_snd fun p ↦ le_add_left le_rfl | ||
| | (a : ℕ), (b : ℕ) => simp [ContinuousAt, nhds_prod_eq, tendsto_pure_nhds] | ||
| | (a : ℕ), (b : ℕ) => simp [ContinuousAt, nhds_prod_eq] |
Collaborator
Author
There was a problem hiding this comment.
No longer required since add_eq_top above is @[simp]
Contributor
|
Thanks for doing this! |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
backward.isDefEq.respectTransparencybackward.isDefEq.respectTransparency
michaellee94
pushed a commit
to michaellee94/mathlib4
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through and found a few remaining instances of
ENat/WithTop Natdefeq abuse that were easy to fix.