Skip to content

feat(Analysis/CStarAlgebra/Matrix): add CStarAlgebra instance for matrices#41518

Open
judsonpereirademoura-netizen wants to merge 4 commits into
leanprover-community:masterfrom
judsonpereirademoura-netizen:patch-1
Open

feat(Analysis/CStarAlgebra/Matrix): add CStarAlgebra instance for matrices#41518
judsonpereirademoura-netizen wants to merge 4 commits into
leanprover-community:masterfrom
judsonpereirademoura-netizen:patch-1

Conversation

@judsonpereirademoura-netizen

Copy link
Copy Markdown

Adds the bundled CStarAlgebra instance for Matrix n n ℂ in the L2 operator norm (Mathlib already has CStarRing scoped in Matrix.Norms.L2Operator, but not the bundled algebra). Composed from the existing scoped instances. Follow-up to #40900.

Define the instance of CStarAlgebra for matrices with L2 operator norm.
@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

PR summary 59bc3226f8

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Analysis.CStarAlgebra.Matrix 2210 2214 +4 (+0.18%)
Import changes for all files
Files Import difference
6 files Mathlib.Analysis.CStarAlgebra.Matrix Mathlib.Analysis.Convex.Birkhoff Mathlib.Analysis.Convex.DoublyStochasticMatrix Mathlib.LinearAlgebra.Matrix.Permutation Mathlib.LinearAlgebra.Matrix.Stochastic Mathlib.LinearAlgebra.Matrix.Swap
4

Declarations diff (regex)

+ instCStarAlgebra

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 59bc322).

  • +1 new declarations
  • −0 removed declarations
+Matrix.instCStarAlgebra

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 59bc3226f8
Reference commit 80ffd59621

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Jul 9, 2026
@judsonpereirademoura-netizen judsonpereirademoura-netizen changed the title feat(Analysis/CStarAlgebra/Matrix): CStarAlgebra instance for matrices feat(Analysis/CStarAlgebra/Matrix): add CStarAlgebra instance for matrices Jul 9, 2026
Removed unnecessary comments and cleaned up the definition of the CStarAlgebra instance.
Comment thread Mathlib/Analysis/CStarAlgebra/Matrix.lean Outdated
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
@judsonpereirademoura-netizen

Copy link
Copy Markdown
Author

Thanks for the review! Applied the where suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants