feat(Analysis/CStarAlgebra/Matrix): add CStarAlgebra instance for matrices#41518
Conversation
Define the instance of CStarAlgebra for matrices with L2 operator norm.
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 59bc3226f8
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Analysis.CStarAlgebra.Matrix | 2210 | 2214 | +4 (+0.18%) |
Import changes for all files
| Files | Import difference |
|---|---|
6 filesMathlib.Analysis.CStarAlgebra.Matrix Mathlib.Analysis.Convex.Birkhoff Mathlib.Analysis.Convex.DoublyStochasticMatrix Mathlib.LinearAlgebra.Matrix.Permutation Mathlib.LinearAlgebra.Matrix.Stochastic Mathlib.LinearAlgebra.Matrix.Swap |
4 |
Declarations diff (regex)
+ instCStarAlgebra
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
59bc322).
- +1 new declarations
- −0 removed declarations
+Matrix.instCStarAlgebraNo changes to strong technical debt.
No changes to weak technical debt.
Current commit 59bc3226f8
Reference commit 80ffd59621
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
Removed unnecessary comments and cleaned up the definition of the CStarAlgebra instance.
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
|
Thanks for the review! Applied the where suggestion. |
Adds the bundled CStarAlgebra instance for Matrix n n ℂ in the L2 operator norm (Mathlib already has CStarRing scoped in Matrix.Norms.L2Operator, but not the bundled algebra). Composed from the existing scoped instances. Follow-up to #40900.