feat(Topology/EMetricSpace/BoundedVariation): more BoundedVariationOn and eVariationOn API#41519
feat(Topology/EMetricSpace/BoundedVariation): more BoundedVariationOn and eVariationOn API#41519teorth wants to merge 27 commits into
Conversation
PR summary e74f9ee260
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Topology.EMetricSpace.BoundedVariation | 1339 | 1341 | +2 (+0.15%) |
Import changes for all files
| Files | Import difference |
|---|---|
4 filesMathlib.Analysis.ConstantSpeed Mathlib.MeasureTheory.VectorMeasure.BoundedVariation Mathlib.Topology.EMetricSpace.BoundedVariation Mathlib.Topology.EMetricSpace.VariationOnFromTo |
2 |
Declarations diff (regex)
+ BoundedVariationOn.id_Icc
+ MonotoneOn.eVariationOn_eq
+ _root_.BoundedVariationOn.of_finite
+ _root_.BoundedVariationOn.of_finset
+ eVariationOn_id
+ eVariationOn_id_Icc
+ image_range_of_monotone
+ pair
+ union'
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
e74f9ee).
- +8 new declarations
- −0 removed declarations
+BoundedVariationOn.id_Icc
+BoundedVariationOn.of_finite
+MonotoneOn.eVariationOn_eq
+eVariationOn.image_range_of_monotone
+eVariationOn.pair
+eVariationOn.union'
+eVariationOn_id
+eVariationOn_id_IccNo changes to strong technical debt.
No changes to weak technical debt.
Current commit e74f9ee260
Reference commit 69b866d83a
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
|
Most comments are about the coding style and relatively minor. The only major concern I have is |
|
awaiting-author |
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
…into boundedvariation
…dedVariationOn.of_finite
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
|
I have now folded the proof of -awaiting-author |
|
I think this LGTM now, I'll put it on the maintainer queue after you address the comments. awaiting-author |
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
Co-authored-by: Yongxi (Aaron) Lin <97214596+CoolRmal@users.noreply.github.com>
|
-awaiting-author |
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by CoolRmal. |
Various API for
BoundedVariationOnandeVariationOn, including a formula for theeVariationOnfor finite sets such as pairs, or the variation of the identity function, or more generally a monotone function.Note: to obtain the variation formula for finite sets,
Data.Finset.Sortwas added to the imports.