Skip to content

feat: scalar multiplication as a CLM on D^n#41531

Open
luigi-massacci wants to merge 29 commits into
leanprover-community:masterfrom
luigi-massacci:LM_mul_distrib_III
Open

feat: scalar multiplication as a CLM on D^n#41531
luigi-massacci wants to merge 29 commits into
leanprover-community:masterfrom
luigi-massacci:LM_mul_distrib_III

Conversation

@luigi-massacci

@luigi-massacci luigi-massacci commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

PR summary fe6c7c5d2f

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Analysis.Distribution.ContDiffMapSupportedIn 2395 2404 +9 (+0.38%)
Mathlib.Analysis.Distribution.TestFunction 2433 2440 +7 (+0.29%)
Import changes for all files
Files Import difference
Mathlib.Analysis.Distribution.Distribution Mathlib.Analysis.Distribution.TestFunction 7
Mathlib.Analysis.Distribution.ContDiffMapSupportedIn 9

Declarations diff (regex)

+ bilinLeftCLM
+ instance : ContinuousConstSMul 𝕜 𝓓^{n}(Ω, F)
+ smulLeftCLM
+ smulLeftCLM_add
+ smulLeftCLM_apply
+ smulLeftCLM_apply_apply
+ smulLeftCLM_compL_smulLeftCLM
+ smulLeftCLM_const
+ smulLeftCLM_neg
+ smulLeftCLM_smul
+ smulLeftCLM_smulLeftCLM_apply
+ smulLeftCLM_sub
++ bilinLeftCLM_apply
- fderivCLM
- instance : LineDeriv E 𝓓(Ω, F) 𝓓(Ω, F)
- integralAgainstBilinCLM
- lineDerivCLM
- monoCLM
- ofSupportedInCLM
- originalTop
- postcompCLM
- toBoundedContinuousFunctionCLM

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit fe6c7c5).

  • +17 new declarations
  • −0 removed declarations
+ContDiffMapSupportedIn.bilinLeftCLM
+ContDiffMapSupportedIn.bilinLeftCLM_apply
+ContDiffMapSupportedIn.mk.congr_simp
+TestFunction.bilinLeftCLM
+TestFunction.bilinLeftCLM.congr_simp
+TestFunction.bilinLeftCLM_apply
+TestFunction.instContinuousConstSMul
+TestFunction.smulLeftCLM
+TestFunction.smulLeftCLM_add
+TestFunction.smulLeftCLM_apply
+TestFunction.smulLeftCLM_apply_apply
+TestFunction.smulLeftCLM_compL_smulLeftCLM
+TestFunction.smulLeftCLM_const
+TestFunction.smulLeftCLM_neg
+TestFunction.smulLeftCLM_smul
+TestFunction.smulLeftCLM_smulLeftCLM_apply
+TestFunction.smulLeftCLM_sub

No changes to strong technical debt.

No changes to weak technical debt.

Current commit fe6c7c5d2f
Reference commit ed0d70fdcd

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Jul 9, 2026
@luigi-massacci

Copy link
Copy Markdown
Collaborator Author

I would like to get feedback most of all on the ContinuousConstSMul instance. I don't know if this is the proper way to do it, it feels a bit teleological. I'm unsure if this partially resolves the existing TODO for ContinuousSMul or is just an abomination. I needed the instance for smulLeftCLM_const.

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 9, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-analysis Analysis (normed *, calculus)

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant