Skip to content

[Merged by Bors] - doc: fix docstring of orthogonalProjectionOnto#41568

Closed
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-39041-projection-docstring
Closed

[Merged by Bors] - doc: fix docstring of orthogonalProjectionOnto#41568
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-39041-projection-docstring

Conversation

@kim-em

@kim-em kim-em commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR fixes the docstring of Submodule.orthogonalProjectionOnto, which said "complete subspace" (a leftover from the removed orthogonalProjectionFn docstring), even though the hypothesis [K.HasOrthogonalProjection] is strictly weaker than completeness. Restore the pre-existing wording "The orthogonal projection onto a subspace.", matching the deprecated orthogonalProjection abbrev just below.


Follow-up to #39041 (refactor: redefine orthogonalProjectionOnto via projectionOntoL).

🤖 Prepared with Claude Code

The hypothesis is `[K.HasOrthogonalProjection]`, which is strictly weaker
than completeness, so restore the pre-leanprover-community#39041 wording.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary 2d594f0a03

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 2d594f0).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 2d594f0a03
Reference commit a33a5ccd63

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Jul 10, 2026
@themathqueen themathqueen marked this pull request as ready for review July 10, 2026 21:31
@themathqueen themathqueen added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 10, 2026

@themathqueen themathqueen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 10, 2026

@j-loreaux j-loreaux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 10, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 10, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 10, 2026
This PR fixes the docstring of `Submodule.orthogonalProjectionOnto`, which said "complete subspace" (a leftover from the removed `orthogonalProjectionFn` docstring), even though the hypothesis `[K.HasOrthogonalProjection]` is strictly weaker than completeness. Restore the pre-existing wording "The orthogonal projection onto a subspace.", matching the deprecated `orthogonalProjection` abbrev just below.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 10, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title doc: fix docstring of orthogonalProjectionOnto [Merged by Bors] - doc: fix docstring of orthogonalProjectionOnto Jul 10, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 10, 2026
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Jul 11, 2026
…41568)

This PR fixes the docstring of `Submodule.orthogonalProjectionOnto`, which said "complete subspace" (a leftover from the removed `orthogonalProjectionFn` docstring), even though the hypothesis `[K.HasOrthogonalProjection]` is strictly weaker than completeness. Restore the pre-existing wording "The orthogonal projection onto a subspace.", matching the deprecated `orthogonalProjection` abbrev just below.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants