[Merged by Bors] - doc: fix docstring of orthogonalProjectionOnto#41568
Closed
kim-em wants to merge 1 commit into
Closed
[Merged by Bors] - doc: fix docstring of orthogonalProjectionOnto#41568kim-em wants to merge 1 commit into
kim-em wants to merge 1 commit into
Conversation
The hypothesis is `[K.HasOrthogonalProjection]`, which is strictly weaker than completeness, so restore the pre-leanprover-community#39041 wording. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PR summary 2d594f0a03Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
🚀 Pull request has been placed on the maintainer queue by themathqueen. |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jul 10, 2026
This PR fixes the docstring of `Submodule.orthogonalProjectionOnto`, which said "complete subspace" (a leftover from the removed `orthogonalProjectionFn` docstring), even though the hypothesis `[K.HasOrthogonalProjection]` is strictly weaker than completeness. Restore the pre-existing wording "The orthogonal projection onto a subspace.", matching the deprecated `orthogonalProjection` abbrev just below.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
michaellee94
pushed a commit
to michaellee94/mathlib4
that referenced
this pull request
Jul 11, 2026
…41568) This PR fixes the docstring of `Submodule.orthogonalProjectionOnto`, which said "complete subspace" (a leftover from the removed `orthogonalProjectionFn` docstring), even though the hypothesis `[K.HasOrthogonalProjection]` is strictly weaker than completeness. Restore the pre-existing wording "The orthogonal projection onto a subspace.", matching the deprecated `orthogonalProjection` abbrev just below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the docstring of
Submodule.orthogonalProjectionOnto, which said "complete subspace" (a leftover from the removedorthogonalProjectionFndocstring), even though the hypothesis[K.HasOrthogonalProjection]is strictly weaker than completeness. Restore the pre-existing wording "The orthogonal projection onto a subspace.", matching the deprecatedorthogonalProjectionabbrev just below.Follow-up to #39041 (refactor: redefine orthogonalProjectionOnto via projectionOntoL).
🤖 Prepared with Claude Code