Skip to content

[Merged by Bors] - chore(Topology/DiscreteSubset): fix typo eventualy -> eventually in lemma name#41569

Closed
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-39353-eventually-typo
Closed

[Merged by Bors] - chore(Topology/DiscreteSubset): fix typo eventualy -> eventually in lemma name#41569
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-39353-eventually-typo

Conversation

@kim-em

@kim-em kim-em commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR renames Disjoint.eventualy_nhdsWithin_specializes to Disjoint.eventually_nhdsWithin_specializes, fixing the misspelling "eventualy", and update its single (internal) use site. The lemma was merged three days ago and has not been in any release, so no deprecated alias is added.


Follow-up to #39353 (feat(Topology): Show existence of a neighbourhood around p which avoids all points in the support of a locally finsupp function except those which specialize to p).

🤖 Prepared with Claude Code

…emma name

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary 01737d1046

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ Disjoint.eventually_nhdsWithin_specializes
- Disjoint.eventualy_nhdsWithin_specializes

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 01737d1).

  • +1 new declarations
  • −1 removed declarations
+Disjoint.eventually_nhdsWithin_specializes
-Disjoint.eventualy_nhdsWithin_specializes

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 01737d1046
Reference commit a33a5ccd63

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@themathqueen themathqueen marked this pull request as ready for review July 10, 2026 21:34
@themathqueen themathqueen added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 10, 2026

@themathqueen themathqueen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 10, 2026

@j-loreaux j-loreaux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 10, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 10, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 10, 2026
…emma name (#41569)

This PR renames `Disjoint.eventualy_nhdsWithin_specializes` to `Disjoint.eventually_nhdsWithin_specializes`, fixing the misspelling "eventualy", and update its single (internal) use site. The lemma was merged three days ago and has not been in any release, so no deprecated alias is added.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 10, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title chore(Topology/DiscreteSubset): fix typo eventualy -> eventually in lemma name [Merged by Bors] - chore(Topology/DiscreteSubset): fix typo eventualy -> eventually in lemma name Jul 10, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 10, 2026
michaellee94 pushed a commit to michaellee94/mathlib4 that referenced this pull request Jul 11, 2026
…emma name (leanprover-community#41569)

This PR renames `Disjoint.eventualy_nhdsWithin_specializes` to `Disjoint.eventually_nhdsWithin_specializes`, fixing the misspelling "eventualy", and update its single (internal) use site. The lemma was merged three days ago and has not been in any release, so no deprecated alias is added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants