Skip to content

doc: fix and add docstrings in RingTheory/Invariant/Galois#41570

Draft
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-40247-invariant-docstrings
Draft

doc: fix and add docstrings in RingTheory/Invariant/Galois#41570
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-40247-invariant-docstrings

Conversation

@kim-em

@kim-em kim-em commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR fixes the docstring of Ideal.Quotient.normal, which was copy-pasted from Ideal.Quotient.exists_algHom_fixedPoint_quotient_under and did not describe the statement Normal (A ⧸ P) (B ⧸ Q), and add docstrings to Ideal.IsFractionRing.normal and Ideal.IsFractionRing.finite_of_isInvariant, matching the phrasing of the sibling results in RingTheory/Invariant/Basic.lean.

Follow-up to #40247 (feat(RingTheory/Invariant/Basic): generalize Ideal.Quotient.normal to IsFractionRing).

🤖 Prepared with Claude Code

Ideal.Quotient.normal carried a copy-pasted docstring from
Ideal.Quotient.exists_algHom_fixedPoint_quotient_under that did not
describe its statement. Replace it, and add docstrings to
Ideal.IsFractionRing.normal and
Ideal.IsFractionRing.finite_of_isInvariant.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the t-ring-theory Ring theory label Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary 22f75dfcf4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 22f75df).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 22f75dfcf4
Reference commit a33a5ccd63

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant