doc: fix and add docstrings in RingTheory/Invariant/Galois#41570
Draft
kim-em wants to merge 1 commit into
Draft
Conversation
Ideal.Quotient.normal carried a copy-pasted docstring from Ideal.Quotient.exists_algHom_fixedPoint_quotient_under that did not describe its statement. Replace it, and add docstrings to Ideal.IsFractionRing.normal and Ideal.IsFractionRing.finite_of_isInvariant. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PR summary 22f75dfcf4Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the docstring of
Ideal.Quotient.normal, which was copy-pasted fromIdeal.Quotient.exists_algHom_fixedPoint_quotient_underand did not describe the statementNormal (A ⧸ P) (B ⧸ Q), and add docstrings toIdeal.IsFractionRing.normalandIdeal.IsFractionRing.finite_of_isInvariant, matching the phrasing of the sibling results inRingTheory/Invariant/Basic.lean.Follow-up to #40247 (feat(RingTheory/Invariant/Basic): generalize
Ideal.Quotient.normaltoIsFractionRing).🤖 Prepared with Claude Code