chore(Analysis/RCLike): move I_smul_of_mem_skewAdjoint out of IsSelfAdjoint namespace#41575
Closed
kim-em wants to merge 1 commit into
Closed
Conversation
…djoint namespace The hypothesis is `a ∈ skewAdjoint A`, not `IsSelfAdjoint _`, so the namespace never enables dot notation; mirror `isSelfAdjoint_smul_of_mem_skewAdjoint`, the lemma it is proved from. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PR summary d00dc201c7Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Comment on lines
+781
to
782
| lemma isSelfAdjoint_I_smul_of_mem_skewAdjoint (h : a ∈ skewAdjoint A) : | ||
| IsSelfAdjoint ((I : K) • a) := isSelfAdjoint_smul_of_mem_skewAdjoint I_mem_skewAdjoint h |
Collaborator
There was a problem hiding this comment.
I mean... you could still do have : IsSelfAdjoint _ := .I_smul_of_mem_skewAdjoint h
so you could technically use dot notation here
Contributor
|
Closed because this can use anonymous dot notation still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
IsSelfAdjoint.I_smul_of_mem_skewAdjointto the root-namespaceisSelfAdjoint_I_smul_of_mem_skewAdjoint, with a deprecated alias for the old name. The lemma's hypothesis isa ∈ skewAdjoint A, notIsSelfAdjoint _, so theIsSelfAdjointnamespace never enables dot notation; the new name mirrorsisSelfAdjoint_smul_of_mem_skewAdjoint, the general lemma it is proved from, whose dot-notation siblingIsSelfAdjoint.smul_mem_skewAdjointkeeps the namespace for the same reason.Follow-up to #40684 (feat: some API for relating self-adjoint and skew-adjoints).
🤖 Prepared with Claude Code