Skip to content

chore(Analysis/RCLike): move I_smul_of_mem_skewAdjoint out of IsSelfAdjoint namespace#41575

Closed
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-40684-selfadjoint-name
Closed

chore(Analysis/RCLike): move I_smul_of_mem_skewAdjoint out of IsSelfAdjoint namespace#41575
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-40684-selfadjoint-name

Conversation

@kim-em

@kim-em kim-em commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR renames IsSelfAdjoint.I_smul_of_mem_skewAdjoint to the root-namespace isSelfAdjoint_I_smul_of_mem_skewAdjoint, with a deprecated alias for the old name. The lemma's hypothesis is a ∈ skewAdjoint A, not IsSelfAdjoint _, so the IsSelfAdjoint namespace never enables dot notation; the new name mirrors isSelfAdjoint_smul_of_mem_skewAdjoint, the general lemma it is proved from, whose dot-notation sibling IsSelfAdjoint.smul_mem_skewAdjoint keeps the namespace for the same reason.

Follow-up to #40684 (feat: some API for relating self-adjoint and skew-adjoints).

🤖 Prepared with Claude Code

…djoint namespace

The hypothesis is `a ∈ skewAdjoint A`, not `IsSelfAdjoint _`, so the
namespace never enables dot notation; mirror
`isSelfAdjoint_smul_of_mem_skewAdjoint`, the lemma it is proved from.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary d00dc201c7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ isSelfAdjoint_I_smul_of_mem_skewAdjoint

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit d00dc20).

  • +1 new declarations
  • −0 removed declarations
+isSelfAdjoint_I_smul_of_mem_skewAdjoint

No changes to strong technical debt.

No changes to weak technical debt.

Current commit d00dc201c7
Reference commit a33a5ccd63

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment on lines +781 to 782
lemma isSelfAdjoint_I_smul_of_mem_skewAdjoint (h : a ∈ skewAdjoint A) :
IsSelfAdjoint ((I : K) • a) := isSelfAdjoint_smul_of_mem_skewAdjoint I_mem_skewAdjoint h

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean... you could still do have : IsSelfAdjoint _ := .I_smul_of_mem_skewAdjoint h
so you could technically use dot notation here

@j-loreaux j-loreaux closed this Jul 10, 2026
@j-loreaux

Copy link
Copy Markdown
Contributor

Closed because this can use anonymous dot notation still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants