Skip to content

chore: add gcongr attribute to Nat.ascFactorial_le and Nat.descFactorial_le#41577

Draft
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-40816-gcongr-ascfactorial
Draft

chore: add gcongr attribute to Nat.ascFactorial_le and Nat.descFactorial_le#41577
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-40816-gcongr-ascfactorial

Conversation

@kim-em

@kim-em kim-em commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR adds the @[gcongr] attribute to Nat.ascFactorial_le and to the identically-shaped Nat.descFactorial_le, so that gcongr can rewrite under ascFactorial/descFactorial. Nat.factorial_le in the same file is already tagged @[mono, gcongr].

Follow-up to #40816 (feat(Data/Nat/Factorial/Basic): add ascFactorial_le).

🤖 Prepared with Claude Code

…ial_le

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary e1f3c08546

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit e1f3c08).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit e1f3c08546
Reference commit a33a5ccd63

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant