Skip to content

chore(Geometry/Euclidean/Sphere): drop unneeded distinctness hypothesis#41582

Draft
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-41143-sphere-diameter
Draft

chore(Geometry/Euclidean/Sphere): drop unneeded distinctness hypothesis#41582
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:claude/followup-41143-sphere-diameter

Conversation

@kim-em

@kim-em kim-em commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR removes the p₁ ≠ p₂ hypothesis from Sphere.center_mem_affineSpan_pair_iff_isDiameter: the iff also holds when the points coincide (both sides then say p₁ = s.center), and the neighbouring isDiameter_iff_* lemmas carry no distinctness hypotheses. The degenerate case is handled by a one-line simp.

Follow-up to #41143 (feat(Geometry/Euclidean/Sphere): lemmas about points on a sphere).

🤖 Prepared with Claude Code

The iff in `Sphere.center_mem_affineSpan_pair_iff_isDiameter` also holds
when the two points coincide, matching the neighbouring `isDiameter_iff_*`
lemmas which carry no distinctness hypotheses.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary b22e721b7f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit b22e721).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit b22e721b7f
Reference commit a33a5ccd63

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-euclidean-geometry Affine and axiomatic geometry label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant