chore: move simple_obj into Functor namespace, golf proofs, tidy docstring#41583
Draft
kim-em wants to merge 1 commit into
Draft
chore: move simple_obj into Functor namespace, golf proofs, tidy docstring#41583kim-em wants to merge 1 commit into
kim-em wants to merge 1 commit into
Conversation
…tring Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PR summary 65a3e33478Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
CategoryTheory.simple_objandCategoryTheory.simple_obj_iffinto theFunctornamespace (matching their siblingFunctor.simple_of_simple_objand enabling dot notation), golfFunctor.simple_objand the forward direction ofisSimpleModule_iff_eq_zero_or_injectivevia the existingLinearMap.injective_or_eq_zero, remove unusedvariablebinders inRingTheory/SimpleRing/DivisionRing.lean, and fix inverted heading levels and an "an unique" typo in that file's module docstring. The one call site of the renamed lemmas is updated; no deprecated aliases are added since the declarations merged a week ago.Follow-up to #41233 (feat(SimpleRing/DivisionRing): simple module is preserved by ModuleCat equivs).
🤖 Prepared with Claude Code