Skip to content

chore(Order/ConditionallyCompletePartialOrder/Indexed): use to_dual more to kill TODO#41589

Open
yuanyi-350 wants to merge 2 commits into
leanprover-community:masterfrom
yuanyi-350:to_dual
Open

chore(Order/ConditionallyCompletePartialOrder/Indexed): use to_dual more to kill TODO#41589
yuanyi-350 wants to merge 2 commits into
leanprover-community:masterfrom
yuanyi-350:to_dual

Conversation

@yuanyi-350

@yuanyi-350 yuanyi-350 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

This PR uses to_dual to translate some theorems about ConditionallyCompletePartialOrder and kill TODO.


Open in Gitpod

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary 1f8470a8e1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

- map_ciInf_of_directed
- map_ciInf_set_of_directedOn
- map_csInf_of_directedOn
- map_csInf_of_directedOn'
- u_ciInf_of_directed
- u_ciInf_set_of_directedOn
- u_csInf_of_directedOn
- u_csInf_of_directedOn'

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 1f8470a).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 1f8470a8e1
Reference commit c368140668

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-order Order theory label Jul 10, 2026
@yuanyi-350 yuanyi-350 requested a review from j-loreaux July 10, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant