WIP: inline noncomputable sections

[felixpernegger]

---

[felixpernegger]

WIP

[mathlib-bors]

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

[felixpernegger]

!bench

[leanprover-radar]

Benchmark results for 0f410ca against a08ff0d are in. There are significant results. @felixpernegger

• 🟥 main exited with code 1

No significant changes detected.

[github-actions]

PR summary b82ba6f9c1

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

---

Declarations diff (regex)

-+-+ H0IsoOfIsTrivial
-+-+ H1Iso
-+-+ H2Iso
-+-+ R
-+-+ comparisonAdjunction
-+-+ continuousAlternatingMap
-+-+ degreeLE
-+-+ distortion
-+-+ epiIsCokernelOfKernel
-+-+ equivFinRank
-+-+ existsPullbackAdj
-+-+ forgetCreatesPullbackOfLeft
-+-+ forgetCreatesPullbackOfRight
-+-+ fundamentalGroupEquiv
-+-+ im
-+-+ instance (x : PrimeSpectrum.Top R) :
-+-+ instance (x : X) : Field (X.residueField x)
-+-+ isKanWhisker
-+-+ lift
-+-+ liftMagma
-+-+ limitConeIsLimit
-+-+ limitSemiring
-+-+ monoIsKernelOfCokernel
-+-+ pullbackId
-+-+ residueField
-+-+ shortComplexH0
-+-+ vPullbackCone
-+-+-+ colimitCoconeIsColimit
-+-+-+ instance (U : (Opens (PrimeSpectrum.Top R))ᵒᵖ) :
-+-+-+ instance :
-+-+-+ vPullbackConeIsLimit
-+-+-+-+-+ colimitCocone
-+-+-+-+-+-+ limitCone

You can run this locally as follows

## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit b82ba6f).

• +0 new declarations
• −0 removed declarations

No declaration differences.

---

No changes to strong technical debt.

No changes to weak technical debt.

Current commit b82ba6f9c1
Reference commit 1857d442a8

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary

• The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
• The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

[github-actions]

🚨 PR Title Needs Formatting

Please update the title to match our commit style conventions.

Errors from script:

labels are []
error: the PR title should be of the form
  kind: subject
or
  kind(scope): subject
Allowed values for `kind` are [feat, chore, perf, refactor, style, fix, doc, test, ci]

Details on the required title format

The title should fit the following format:

<kind>(<optional-scope>): <subject>

<kind> is:

• feat (feature)
• fix (bug fix)
• doc (documentation)
• style (formatting, missing semicolons, ...)
• refactor
• test (when adding missing tests)
• chore (maintain)
• perf (performance improvement, optimization, ...)
• ci (changes to continuous integration, repo automation, ...)

<optional-scope> is a name of module or a directory which contains changed modules.
This is not necessary to include, but may be useful if the <subject> is insufficient.
The Mathlib directory prefix is always omitted.
For instance, it could be

• Data/Nat/Basic
• Algebra/Group/Defs
• Topology/Constructions

<subject> has the following constraints:

• do not capitalize the first letter
• no dot(.) at the end
• use imperative, present tense: "change" not "changed" nor "changes"

[felixpernegger]

!bench

[leanprover-radar]

Benchmark results for 48e0354 against 1857d44 are in. There are significant results. @felixpernegger

• 🟥 main exited with code 1

No significant changes detected.

[felixpernegger]

!bench

[leanprover-radar]

Benchmark results for e0d7cc1 against 1857d44 are in. There are significant results. @felixpernegger

• 🟥 main exited with code 1

No significant changes detected.

[felixpernegger]

!bench

[leanprover-radar]

Benchmark results for b82ba6f against 1857d44 are in. No significant results found. @felixpernegger

• ✅ build//instructions: -9.9G (-0.01%)

No significant changes detected.

[mathlib-merge-conflicts]

This pull request has conflicts, please merge master and resolve them.