feat(NumberTheory/Height/NumberField): comparison of heights across extensions of number fields#41606
Open
tb65536 wants to merge 8 commits into
Open
feat(NumberTheory/Height/NumberField): comparison of heights across extensions of number fields#41606tb65536 wants to merge 8 commits into
tb65536 wants to merge 8 commits into
Conversation
tb65536
added
awaiting-CI
PR summary 70bcdebf97
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.Height.NumberField | 3207 | 3211 | +4 (+0.12%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.NumberTheory.Height.NumberField |
4 |
Declarations diff (regex)
+ _root_.NumberField.FinitePlace.equivHeightOneSpectrum_symm_apply_algebraMap
+ _root_.NumberField.InfinitePlace.liesOver_iff_comap_eq
+ absMulHeight₁
+ absMulHeight₁_eq
+ finrank_nsmul_logHeight
+ finrank_nsmul_logHeight₁
+ foobar_mul
+ mulHeight_pow_finrank
+ mulHeight_pow_finrank_aux
+ mulHeight₁_pow_finrank
+ mult_mul_finrank
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean -- pending)
Computed after the build finishes.
No changes to strong technical debt.
No changes to weak technical debt.
Current commit 70bcdebf97
Reference commit a33a5ccd63
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
mathlib-dependent-issues
Bot
added
the
blocked-by-other-PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proves that that the heights defined in
NumberTheory/Height/NumberFieldare compatible across extensions of number fields.InfinitePlace.mult_mul_finrank#41600