Skip to content

chore(RingTheory/DedekindDomain): update definitions#41607

Open
mbkybky wants to merge 2 commits into
leanprover-community:masterfrom
mbkybky:IsDedekindDomainDvrUpdateDef
Open

chore(RingTheory/DedekindDomain): update definitions#41607
mbkybky wants to merge 2 commits into
leanprover-community:masterfrom
mbkybky:IsDedekindDomainDvrUpdateDef

Conversation

@mbkybky

@mbkybky mbkybky commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Update IsDedekindRing and IsDedekindDomainDvr to extend IsNoetherianRing A instead of IsNoetherian A A, bringing their definitions closer to the usual mathematical formulations.


Open in Gitpod

@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

PR summary 78aef9280c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 78aef92).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 78aef9280c
Reference commit 1c3e8f34a8

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant