Skip to content

chore(RingTheory/DedekindDomain): update definitions #41607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbkybky wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

chore(RingTheory/DedekindDomain): update definitions #41607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c54e60f
Update Dvr.lean
mbkybky Jul 11, 2026
78aef92
Update Basic.lean
mbkybky Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Mathlib/RingTheory/DedekindDomain/Basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ The integral closure condition is independent of the choice of field of fraction
use `isDedekindRing_iff` to prove `IsDedekindRing` for a given `fraction_map`.
-/
class IsDedekindRing : Prop
extends IsNoetherian A A, DimensionLEOne A, IsIntegralClosure A A (FractionRing A)
extends IsNoetherianRing A, DimensionLEOne A, IsIntegralClosure A A (FractionRing A)

/-- An integral domain is a Dedekind domain if and only if it is
Noetherian, has dimension ≤ 1, and is integrally closed in a given fraction field.
Expand Down
2 changes: 1 addition & 1 deletion Mathlib/RingTheory/DedekindDomain/Dvr.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ localization at every nonzero prime is a discrete valuation ring.
This is equivalent to `IsDedekindDomain`.
-/
class IsDedekindDomainDvr : Prop extends IsNoetherian A A where
class IsDedekindDomainDvr : Prop extends IsNoetherianRing A where
is_dvr_at_nonzero_prime : ∀ P ≠ (⊥ : Ideal A), ∀ _ : P.IsPrime,
IsDiscreteValuationRing (Localization.AtPrime P)

Expand Down
Loading