Skip to content

feat(Data/List/Dedup): dedup and Nodup lemmas#41609

Open
SnirBroshi wants to merge 1 commit into
leanprover-community:masterfrom
SnirBroshi:feature/list/more-dedup-nodup-lemmas
Open

feat(Data/List/Dedup): dedup and Nodup lemmas#41609
SnirBroshi wants to merge 1 commit into
leanprover-community:masterfrom
SnirBroshi:feature/list/more-dedup-nodup-lemmas

Conversation

@SnirBroshi

Copy link
Copy Markdown
Collaborator

Open in Gitpod

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Jul 11, 2026
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

PR summary e0c30645de

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ nodup_iff_length_dedup_eq
+ nodup_iff_sublist_dedup
+ toFinset_dedup
++ nodup_iff_le_length_dedup

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit e0c3064).

  • +5 new declarations
  • −0 removed declarations
+List.nodup_iff_le_length_dedup
+List.nodup_iff_length_dedup_eq
+List.nodup_iff_sublist_dedup
+List.toFinset_dedup
+nodup_iff_le_length_dedup

No changes to strong technical debt.

No changes to weak technical debt.

Current commit e0c30645de
Reference commit c368140668

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant