Skip to content

fix(Order/Notation): unify at correct transparency in sup/inf delaborators #41619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JovanGerb wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

fix(Order/Notation): unify at correct transparency in sup/inf delaborators #41619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Mathlib/Order/Notation.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,12 @@ private meta def hasLinearOrder (u : Level) (α : Q(Type u)) (cls : Q(Type u →
MetaM Bool := do
try
withNewMCtxDepth do
-- `isDefEq` may call type class search to instantiate `mvar`, so we need the local instances
-- In Lean 4.19 the pretty printer clears local instances, so we re-add them here.
-- TODO(Jovan): remove
-- `isDefEq` may call type class search to instantiate `mvar`, so we need the local instances.
-- Unfortunately, we need to set the local instances manually.
withLocalInstances (← getLCtx).decls.toList.reduceOption do
let mvar ← mkFreshExprMVarQ q($(linearOrderExpr u) $α) (kind := .synthetic)
let inst' : Q($cls $α) := q($toCls $α $mvar)
isDefEq inst inst'
withReducibleAndInstances <| isDefEq inst inst'
catch _ =>
-- For instance, if `LinearOrder` is not yet imported.
return false
Expand Down
Loading