Skip to content

[Merged by Bors] - chore: rename OpenPartialHomeomorph.to_isOpenEmbedding#41854

Closed
scholzhannah wants to merge 1 commit into
leanprover-community:masterfrom
scholzhannah:renameIsEmbedding
Closed

[Merged by Bors] - chore: rename OpenPartialHomeomorph.to_isOpenEmbedding#41854
scholzhannah wants to merge 1 commit into
leanprover-community:masterfrom
scholzhannah:renameIsEmbedding

Conversation

@scholzhannah

Copy link
Copy Markdown
Collaborator

As requested in a PR review here.
I also included a correction of a different docstring.


Open in Gitpod

@github-actions github-actions Bot added the t-differential-geometry Manifolds etc label Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

PR summary 011eaeb83a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ isOpenEmbedding

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 011eaeb).

  • +1 new declarations
  • −0 removed declarations
+OpenPartialHomeomorph.isOpenEmbedding

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 011eaeb83a
Reference commit fd1d54bcac

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 17, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 17, 2026
As requested in a PR review [here](#41045 (comment)).
I also included a correction of a different docstring.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 17, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore: rename OpenPartialHomeomorph.to_isOpenEmbedding [Merged by Bors] - chore: rename OpenPartialHomeomorph.to_isOpenEmbedding Jul 17, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants