chore(Analysis/InnerProductSpace): remove misleading comment#42123
Open
felixpernegger wants to merge 1 commit into
Open
chore(Analysis/InnerProductSpace): remove misleading comment#42123felixpernegger wants to merge 1 commit into
felixpernegger wants to merge 1 commit into
Conversation
PR summary d287a74723Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Member
|
LGTM, thanks! |
|
🚀 Pull request has been placed on the maintainer queue by mcdoll. |
Contributor
|
I tweaked the PR description quite a bit - LGTM now. Thanks! |
Contributor
Author
|
@grunweg bors bugged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment makes no sense any more:
noncomputable sectionchecks first if a def is computable, and only if not, makes it noncomputable. Sononcomputable sectionwouldn't make a difference here (for an example wherenoncomputable defvsnoncomputable sectionmakes a difference see #mathlib4 > noncomputable section @ 💬).Looking at the git history, it used to be marked
noncomputable def, but that was removed in #40091 without comment. This is not a performance issue any more, so the comment can just be removed.(I stumbled about this while reviewing #42122)