Skip to content

Commit 194f0c3

Browse files
benbrastmckieclaude
andcommitted
doc: fix docstrings for primitive bot perspective
Update intuitionisticCompletion docstring — the old wording "Attach a bottom element" was misleading since bot is already a constructor. Change "five-primitive propositional signature" to "five constructors" in Connectives.lean to avoid conflating generators with operations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7cc0961 commit 194f0c3

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

Cslib/Foundations/Logic/Connectives.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ axiom definitions and notation that work uniformly across different formula type
1616
1717
## Design
1818
19-
The hierarchy adopts a hybrid five-primitive propositional signature `{atom, bot, imp, and, or}`,
19+
The hierarchy adopts five constructors `{atom, bot, imp, and, or}`,
2020
following the operator-typeclass direction of fmontesi's PR #607 (one class per operator):
2121
- **Atomic classes**: `HasBot`, `HasImp`, `HasAnd`, `HasOr`
2222
- **Bundled class**: `PropositionalConnectives` (extends `HasBot` and `HasImp`)

Cslib/Logics/Propositional/Defs.lean

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,9 @@ abbrev CPL : Theory Atom :=
142142
omit [DecidableEq Atom] in
143143
lemma dne_mem_cpl (A : Proposition Atom) : (¬¬A → A) ∈ CPL (Atom := Atom) := ⟨A, rfl⟩
144144

145-
/-- Attach a bottom element to a theory `T`, and the principle of explosion for that bottom. -/
145+
/-- Extend a theory `T` to an intuitionistic theory over a larger atom type by adding the principle
146+
of explosion. The atom type is extended with `WithBot` to ensure the result is over a strictly
147+
larger language. -/
146148
@[reducible]
147149
def intuitionisticCompletion (T : Theory Atom) : Theory (WithBot Atom) :=
148150
(WithBot.some <$> T) ∪ IPL

0 commit comments

Comments
 (0)