Skip to content

Commit aa62343

Browse files
authored
chore: route Zulip notifications to nightly-testing-cslib (#548)
This PR retargets the nightly-testing failure-detection workflow and the adaptation-PR helper script from the shared `nightly-testing` channel to the new `#nightly-testing-cslib` channel, in line with the [proposal to split `#nightly-testing`](https://leanprover.zulipchat.com/#narrow/channel/428973-nightly-testing/topic/proposal.20to.20split.20the.20channel/near/592721807) into per-project channels for Mathlib, Batteries, and Cslib. Topic names are unchanged so existing bookmarks and topic links continue to resolve to the same conversations (which were also moved over). The `#nightly-testing-cslib` channel mirrors the original (web-public, history visible to subscribers, anyone can post). Companion PRs: leanprover-community/mathlib4#38946, leanprover-community/mathlib-ci#33, leanprover-community/batteries#1794. 🤖 Prepared with Claude Code
1 parent 3716b27 commit aa62343

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

.github/workflows/report_failures_nightly-testing.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
api-key: ${{ secrets.ZULIP_API_KEY }}
2222
email: 'github-mathlib4-bot@leanprover.zulipchat.com'
2323
organization-url: 'https://leanprover.zulipchat.com'
24-
to: 'nightly-testing'
24+
to: 'nightly-testing-cslib'
2525
type: 'stream'
2626
topic: 'Cslib status updates'
2727
content: |
@@ -101,7 +101,7 @@ jobs:
101101
'num_before': 1,
102102
'num_after': 0,
103103
'narrow': [
104-
{'operator': 'stream', 'operand': 'nightly-testing'},
104+
{'operator': 'stream', 'operand': 'nightly-testing-cslib'},
105105
{'operator': 'topic', 'operand': 'Cslib status updates'},
106106
{'operator': 'sender', 'operand': bot_email}
107107
],
@@ -113,7 +113,7 @@ jobs:
113113
# Post the success message
114114
request = {
115115
'type': 'stream',
116-
'to': 'nightly-testing',
116+
'to': 'nightly-testing-cslib',
117117
'topic': 'Cslib status updates',
118118
'content': f"✅ The latest CI for Cslib's [nightly-testing branch](https://github.com/leanprover/cslib/tree/nightly-testing) has succeeded! ([{os.getenv('SHA')}](https://github.com/${{ github.repository }}/commit/{os.getenv('SHA')}))"
119119
}
@@ -250,7 +250,7 @@ jobs:
250250
api-key: ${{ secrets.ZULIP_API_KEY }}
251251
email: 'github-mathlib4-bot@leanprover.zulipchat.com'
252252
organization-url: 'https://leanprover.zulipchat.com'
253-
to: 'nightly-testing'
253+
to: 'nightly-testing-cslib'
254254
type: 'stream'
255255
topic: 'Cslib status updates'
256256
content: |
@@ -350,7 +350,7 @@ jobs:
350350
'num_before': 1,
351351
'num_after': 0,
352352
'narrow': [
353-
{'operator': 'stream', 'operand': 'nightly-testing'},
353+
{'operator': 'stream', 'operand': 'nightly-testing-cslib'},
354354
{'operator': 'topic', 'operand': 'Cslib bump branch reminders'},
355355
{'operator': 'sender', 'operand': bot_email}
356356
],
@@ -388,7 +388,7 @@ jobs:
388388
# Post the reminder message
389389
request = {
390390
'type': 'stream',
391-
'to': 'nightly-testing',
391+
'to': 'nightly-testing-cslib',
392392
'topic': 'Cslib bump branch reminders',
393393
'content': payload
394394
}

scripts/create-adaptation-pr.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,13 +203,13 @@ if git diff --name-only bump/"$BUMPVERSION" bump/nightly-"$NIGHTLYDATE" | grep -
203203
zulip_title="cslib#$pr_number adaptations for nightly-$NIGHTLYDATE"
204204
zulip_body=$(printf "> %s\n\nPlease review this PR. At the end of the month this diff will land in 'main'." "$pr_title cslib#$pr_number")
205205

206-
echo "Posting the link to the PR in a new thread on the #nightly-testing channel on Zulip"
206+
echo "Posting the link to the PR in a new thread on the #nightly-testing-cslib channel on Zulip"
207207
echo "Here is the message:"
208208
echo "Title: $zulip_title"
209209
echo " Body: $zulip_body"
210210

211211
if command -v zulip-send >/dev/null 2>&1; then
212-
zulip_command="zulip-send --stream nightly-testing --subject \"$zulip_title\" --message \"$zulip_body\""
212+
zulip_command="zulip-send --stream nightly-testing-cslib --subject \"$zulip_title\" --message \"$zulip_body\""
213213
echo "Running the following 'zulip-send' command to do this:"
214214
echo "> $zulip_command"
215215
eval "$zulip_command"

0 commit comments

Comments
 (0)