fix: address Cursor BugBot feedback

- Always close log group (::endgroup::) on both success and failure
- Check for pre-existing directories before cloning to prevent data loss
- Fix misleading notifications when Zulip config is invalid but verification succeeded

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: kim-em

.github/workflows/nanoda-daily.yml

@@ -104,7 +104,9 @@ jobs:
         shell: bash
 
       - name: Validate Zulip configuration
-        if: always() && inputs.notify == 'zulip'
+        id: validate-zulip
+        if: (success() || failure()) && inputs.notify == 'zulip'
+        continue-on-error: true
         env:
           ZULIP_ORG_URL: ${{ inputs.zulip-org-url }}
           ZULIP_API_KEY: ${{ secrets.zulip-api-key }}
@@ -119,7 +121,7 @@ jobs:
           fi
 
       - name: Send Zulip notification on success
-        if: success() && inputs.notify == 'zulip'
+        if: success() && inputs.notify == 'zulip' && steps.validate-zulip.outcome == 'success'
         uses: zulip/github-actions-zulip/send-message@e4c8f27c732ba9bd98ac6be0583096dea82feea5
         with:
           api-key: ${{ secrets.zulip-api-key }}
@@ -132,7 +134,7 @@ jobs:
             ✅ nanoda daily verification [succeeded](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) on `${{ github.sha }}`
 
       - name: Send Zulip notification on failure
-        if: failure() && inputs.notify == 'zulip'
+        if: steps.lean-action.outcome == 'failure' && inputs.notify == 'zulip' && steps.validate-zulip.outcome == 'success'
         uses: zulip/github-actions-zulip/send-message@e4c8f27c732ba9bd98ac6be0583096dea82feea5
         with:
           api-key: ${{ secrets.zulip-api-key }}

scripts/run_nanoda.sh

@@ -9,6 +9,9 @@ echo "Checking environment with nanoda external type checker"
 handle_exit() {
     exit_status=$?
 
+    # Close the log group before cleanup
+    echo "::endgroup::"
+
     # Always cleanup temporary files/directories
     echo "Cleaning up temporary files..."
     rm -rf _lean4export _nanoda_lib _nanoda_export.txt _nanoda_config.json
@@ -18,12 +21,17 @@ handle_exit() {
         echo "::error::nanoda check failed"
     else
         echo "nanoda-status=SUCCESS" >> "$GITHUB_OUTPUT"
-        echo "::endgroup::"
         echo
     fi
 }
 trap handle_exit EXIT
 
+# Check for conflicting directories before we start
+if [ -d "_lean4export" ] || [ -d "_nanoda_lib" ]; then
+    echo "::error::Directories _lean4export or _nanoda_lib already exist. Please remove them before running nanoda."
+    exit 1
+fi
+
 # Step 1: Install Rust if not present
 echo "Checking for Rust installation..."
 if ! command -v cargo &> /dev/null; then