Skip to content

fix: preserve revert argument order#13964

Open
asvitha2000 wants to merge 2 commits into
leanprover:masterfrom
asvitha2000:fix-revert-argument-order
Open

fix: preserve revert argument order#13964
asvitha2000 wants to merge 2 commits into
leanprover:masterfrom
asvitha2000:fix-revert-argument-order

Conversation

@asvitha2000

@asvitha2000 asvitha2000 commented Jun 7, 2026

Copy link
Copy Markdown

This PR preserves the user-specified argument order in the revert tactic.

Fixes #3028.

This changes the revert tactic to call MVarId.revert with preserveOrder := true, so the order written by the user is preserved.

I added a regression test for revert c a b.

I was not able to run the local Lean test because this checkout does not have local build artifacts under build/release/stage1/bin.

@asvitha2000 asvitha2000 requested a review from kim-em as a code owner June 7, 2026 04:10
@asvitha2000

Copy link
Copy Markdown
Author

changelog-language

@github-actions github-actions Bot added the changelog-language Language features and metaprograms label Jun 7, 2026
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 7, 2026
@mathlib-lean-pr-testing

Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase c743a573e305de6caa318e0d2b0782814b8656ce --onto 9c38aeebc6b701e6adb1dd07659718974eeb0306. You can force Mathlib CI using the force-mathlib-ci label. (2026-06-07 05:27:16)

@leanprover-bot

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase c743a573e305de6caa318e0d2b0782814b8656ce --onto 803553a556fd82fa1060efb0c43eda542130cb16. You can force reference manual CI using the force-manual-ci label. (2026-06-07 05:27:17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revert does not respect the argument order

2 participants