fix: lake: skip artifacts already present when staging or unstaging#14002
Closed
marcelolynch wants to merge 1 commit into
Closed
fix: lake: skip artifacts already present when staging or unstaging#14002marcelolynch wants to merge 1 commit into
marcelolynch wants to merge 1 commit into
Conversation
`lake cache unstage` copies artifacts into the local cache unconditionally, and artifacts cached by builds are read-only, so unstaging over a cache that already holds them failed with a permission error. Skip files that already exist — content-addressed names guarantee identical contents — in both `stage` and `unstage`. The existing stage/unstage tests always emptied the cache before unstaging, which is why this went unnoticed; the cache test now also unstages over a populated cache. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
marcelolynch
changed the title
marcelolynch
changed the title
Member
|
Thanks for catching this error and proposing a test! I am implementing a variant of this PR as part of #14036. |
Member
|
Closed after confirming with Marcelo that this has been suitably addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes lake skip files that already exist for
lake cache unstage, which currently copies artifacts into the local cache unconditionally. Artifacts cached by builds are read-only, so unstaging over a cache that already holds them failed with a permission error. The contents are identical by content-addressing, so skipping is correct.Closes #13997