Skip to content

feat: add linter.extra.dupNamespace.consecutiveOnly option to dupNamespace linter#14249

Merged
wkrozowski merged 3 commits into
leanprover:masterfrom
wkrozowski:wojciech/dupNamespace_non_consecutive
Jul 3, 2026
Merged

feat: add linter.extra.dupNamespace.consecutiveOnly option to dupNamespace linter#14249
wkrozowski merged 3 commits into
leanprover:masterfrom
wkrozowski:wojciech/dupNamespace_non_consecutive

Conversation

@wkrozowski

@wkrozowski wkrozowski commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This PR extends dupNamespace linter to allow users to opt-in via linter.extra.dupNamespace.consecutiveOnly option to check non-consecutive repeated usages of namespace components. By default, only consecutive ones are checked. Opting in for non-consecutive checks matches the behaviour introduced in mathlib4#39793.

@wkrozowski wkrozowski added the changelog-language Language features and metaprograms label Jul 2, 2026
Comment thread src/Lean/Linter/Extra/DupNamespace.lean
@github-actions github-actions Bot added toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN labels Jul 2, 2026
@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label Jul 2, 2026
@leanprover-bot

leanprover-bot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jul 2, 2026
@mathlib-lean-pr-testing

mathlib-lean-pr-testing Bot commented Jul 2, 2026

Copy link
Copy Markdown

Mathlib CI status (docs):

mathlib-nightly-testing Bot pushed a commit to leanprover-community/batteries that referenced this pull request Jul 2, 2026
mathlib-nightly-testing Bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jul 2, 2026
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Jul 2, 2026
@wkrozowski
wkrozowski added this pull request to the merge queue Jul 3, 2026
Merged via the queue into leanprover:master with commit 1f1d818 Jul 3, 2026
18 checks passed
wkrozowski added a commit to wkrozowski/lean4 that referenced this pull request Jul 8, 2026
…amespace` linter (leanprover#14249)

This PR extends `dupNamespace` linter to allow users to opt-in via
`linter.extra.dupNamespace.consecutiveOnly` option to check
non-consecutive repeated usages of namespace components. By default,
only consecutive ones are checked. Opting in for non-consecutive checks
matches the behaviour introduced in
[mathlib4#39793](leanprover-community/mathlib4#39793).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants