refactor: split registerParametricAttribute into extension creation and registration#14344
Draft
wkrozowski wants to merge 1 commit into
Draft
refactor: split registerParametricAttribute into extension creation and registration#14344wkrozowski wants to merge 1 commit into
registerParametricAttribute into extension creation and registration#14344wkrozowski wants to merge 1 commit into
Conversation
github-actions
Bot
added
toolchain-available
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits
registerParametricAttributeinto two composable pieces so that a parametric attribute'sgetParamcan consult the attribute's own extension for entries set on other declarations.registerParametricAttributeExtcreates the backing environment extension from the extension-relevant fields alone (ref,preserveOrder,filterExport), andregisterParametricAttributeForExtregisters the attribute over a given extension.registerParametricAttributeis now the composition of the two, so existing callers are unaffected. This is a pure refactor with no behavior change.This is preparatory work for warning when
@[deprecated]points at an already-deprecated declaration (#14336): the deprecation extension can be created first, letting the attribute'sgetParamlook up whether the replacement name is itself deprecated.