perf: construct IntModule.OfNatModule.Q type manually#14346
Merged
Conversation
This PR optimizes the construction of the `grind`-relevant instances for the auxiliary `grind` type `IntModule.OfNatModule.Q`. It was a major bottleneck in Mathlib.
Collaborator
|
Reference manual CI status:
|
|
🥳 |
Contributor
|
!bench mathlib |
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@c3e2c88 against leanprover-community/mathlib4-nightly-testing@55b60c6 are in. There are significant results. @hargoniX Warning These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.
Medium changes (13✅)
Small changes (49✅) Too many entries to display here. View the full report on radar instead. |
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the construction of the
grind-relevant instances for the auxiliarygrindtypeIntModule.OfNatModule.Q. It was a major bottleneck in Mathlib.