Skip to content

perf: construct IntModule.OfNatModule.Q type manually#14346

Merged
leodemoura merged 1 commit into
masterfrom
tc_qstruct
Jul 9, 2026
Merged

perf: construct IntModule.OfNatModule.Q type manually#14346
leodemoura merged 1 commit into
masterfrom
tc_qstruct

Conversation

@leodemoura

Copy link
Copy Markdown
Member

This PR optimizes the construction of the grind-relevant instances for the auxiliary grind type IntModule.OfNatModule.Q. It was a major bottleneck in Mathlib.

This PR optimizes the construction of the `grind`-relevant instances for the auxiliary
`grind` type `IntModule.OfNatModule.Q`. It was a major bottleneck in Mathlib.
@leodemoura leodemoura added the changelog-tactics User facing tactics label Jul 9, 2026
@leodemoura leodemoura enabled auto-merge July 9, 2026 19:14
@leodemoura leodemoura added this pull request to the merge queue Jul 9, 2026
@github-actions github-actions Bot added toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN labels Jul 9, 2026
@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label Jul 9, 2026
@leanprover-bot

leanprover-bot commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Reference manual CI status:

Merged via the queue into master with commit 4c1cf2f Jul 9, 2026
32 checks passed
@cognivore

Copy link
Copy Markdown

🥳

@hargoniX

hargoniX commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

!bench mathlib

@leanprover-radar

leanprover-radar commented Jul 9, 2026

Copy link
Copy Markdown

Benchmark results for leanprover-community/mathlib4-nightly-testing@c3e2c88 against leanprover-community/mathlib4-nightly-testing@55b60c6 are in. There are significant results. @hargoniX

Warning

These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.

  • Bench repo commit hashes for run main differ between commits.
  • build//instructions: -109.3G (-0.07%)

Medium changes (13✅)

  • build/module/Mathlib.Algebra.Polynomial.RuleOfSigns//instructions: -7.6G (-10.75%)
  • build/module/Mathlib.Analysis.Calculus.LHopital//instructions: -7.6G (-21.59%)
  • build/module/Mathlib.Analysis.Calculus.Taylor//instructions: -7.4G (-11.01%)
  • build/module/Mathlib.Analysis.Normed.Lp.Finsupp//instructions: -4.0G (-24.78%)
  • build/module/Mathlib.Analysis.SpecialFunctions.ContinuousFunctionalCalculus.Rpow.IntegralRepresentation//instructions: -8.9G (-6.60%)
  • build/module/Mathlib.Data.Nat.Factorization.Divisors//instructions: -2.1G (-21.69%)
  • build/module/Mathlib.MeasureTheory.Measure.Prokhorov//instructions: -4.8G (-8.09%)
  • build/module/Mathlib.MeasureTheory.VectorMeasure.Variation.Basic//instructions: -6.3G (-14.22%)
  • build/module/Mathlib.MeasureTheory.VectorMeasure.WithDensityVec//instructions: -5.8G (-8.38%)
  • build/module/Mathlib.NumberTheory.ModularForms.LevelOne.DimensionFormula//instructions: -4.4G (-10.55%)
  • build/module/Mathlib.RingTheory.MvPowerSeries.GaussNorm//instructions: -4.0G (-10.42%)
  • build/module/Mathlib.RingTheory.MvPowerSeries.Trunc//instructions: -9.1G (-24.57%)
  • build/module/Mathlib.Topology.EMetricSpace.BoundedVariation//instructions: -10.7G (-9.84%)

Small changes (49✅)

Too many entries to display here. View the full report on radar instead.

@mathlib-lean-pr-testing mathlib-lean-pr-testing Bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jul 9, 2026
@mathlib-lean-pr-testing

Copy link
Copy Markdown

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR builds-mathlib CI has verified that Mathlib builds against this PR changelog-tactics User facing tactics mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants