fix: restore ambient exporting scope in mkAuxDefinition#14442
Merged
Conversation
This PR fixes a regression from #14437 where the auxiliary definitions wrapping `private` references in exposed bodies (`private_decl%`) had their bodies exported, producing dangling references to private constants that broke importing modules (caught by Mathlib CI). `mkAuxDefinition` again adds the declaration under the ambient exporting scope; the `exposeBody` parameter introduced by #14437 is removed. `wrapInstance` instead wraps its `mkAuxDefinition` calls in `withoutExporting (when := !exposeAux)`: the aux names are minted under the ambient exporting scope beforehand, so the aux defs keep their public names and exported signatures while their bodies stay unexported, as required by the `inferInstanceAs` wrapper fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Kha
enabled auto-merge
July 18, 2026 11:20
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression from #14437 where the auxiliary definitions wrapping
privatereferences in exposed bodies (private_decl%) had their bodies exported, producing dangling references to private constants that broke importing modules in Mathlib.