Revert "[CI] Use custom token for 'Update pre-commit hooks' job"#794
Conversation
This reverts commit e2f269c.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9d49f85ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: ./.github/actions/update-precommit | ||
| with: | ||
| token: ${{ secrets.PRECOMMIT_UPDATE_TOKEN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
When the scheduled job creates or updates the PR through .github/actions/update-precommit/action.yml, authenticating with GITHUB_TOKEN prevents its push events from starting workflows and leaves resulting pull_request workflow runs awaiting manual approval. Consequently, the generated pre-commit update PR no longer automatically runs the checks configured in .github/workflows/main.yml and the other pull_request workflows; retaining the custom token is necessary for fully automatic validation.
Useful? React with 👍 / 👎.
|
Coverage report is available for download |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 15 15
Lines 514 514
Branches 202 202
=======================================
Hits 475 475
Misses 5 5
Partials 34 34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Reverts #754