Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-pre-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ jobs:
- name: Update pre-commit hooks
uses: ./.github/actions/update-precommit
with:
token: ${{ secrets.PRECOMMIT_UPDATE_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve automatic CI runs for generated update PRs

When the scheduled job creates or updates the PR through .github/actions/update-precommit/action.yml, authenticating with GITHUB_TOKEN prevents its push events from starting workflows and leaves resulting pull_request workflow runs awaiting manual approval. Consequently, the generated pre-commit update PR no longer automatically runs the checks configured in .github/workflows/main.yml and the other pull_request workflows; retaining the custom token is necessary for fully automatic validation.

Useful? React with 👍 / 👎.

Loading