This repository was archived by the owner on Jul 16, 2026. It is now read-only.
Extract setup steps into Makefile, rewrite install test workflow - #114
Merged
Conversation
rtibbles
force-pushed
the
refactor/makefile-setup-targets
branch
2 times, most recently
from
March 4, 2026 04:31
a60e733 to
9a1839d
Compare
rtibbles
marked this pull request as draft
March 4, 2026 04:32
…flow Add Makefile targets (setup-ppa, install-build-deps, install-upload-deps, install-kolibri) with SUDO auto-detection for use in CI and local dev. Rewrite installtest.yml to build the .deb once on the runner, then test installation across a 5-distro × 2-arch matrix using native ARM runners instead of QEMU cross-compilation. Add ubuntu:24.04 to the matrix. Delete test/Dockerfile (replaced by direct container: usage in workflow). Fix setup_ppa.sh missing execute permission. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…kaging Replace inline apt-get calls with make install-upload-deps. Add missing make install-kolibri step so error-pages can be generated (the source package was previously missing error_pages/). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rtibbles
force-pushed
the
refactor/makefile-setup-targets
branch
from
March 4, 2026 04:33
9a1839d to
8b03666
Compare
rtibbles
marked this pull request as ready for review
March 4, 2026 04:43
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup-ppa,install-build-deps,install-upload-deps,install-kolibri) withSUDOauto-detection for CI and local devinstalltest.yml: build.debonce on the runner, then test across a 5-distro × 2-arch matrix using native ARM runners instead of QEMUbuild_debian.yml: add missingmake install-kolibristep soerror-pagescan be generated (source package was missingerror_pages/)test/Dockerfile(replaced bycontainer:in workflow)test/setup_ppa.shmissing execute permissionTested locally with podman: build on
ubuntu:latestand install ondebian:bookwormboth pass.References
Supersedes the QEMU-based cross-compilation approach which was slow (~13-17 min per job).
Reviewer guidance
build_debian.ymlchange fixes a real bug — kolibri was never installed before packaging, soerror_pages/was missing from the source packageSUDOdetection (id -ucheck) is the main shared piece — verify it works for both root (CI containers) and non-root (dev machines)AI usage
Used Claude Code to implement the plan, iteratively testing with podman containers to verify the build and install flows work end-to-end.