Skip to content

Commit c4c8e82

Browse files
rtibblesbotclaude
andcommitted
Refine label-has-for fixes: simplify computed ref and reuse focused element
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 0fa54b8 commit c4c8e82

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

kolibri/plugins/coach/frontend/views/common/QuestionDetailLearnerList.vue

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
item.focus();
9292
}
9393
this.$emit('select', learnerNumber);
94-
this.scrollToSelectedLearner(learnerNumber);
94+
this.scrollToSelectedLearner(learnerNumber, item);
9595
},
9696
isSelected(learnerNumber) {
9797
return Number(this.selectedLearnerNumber) === learnerNumber;
@@ -102,12 +102,14 @@
102102
nextLearner(learnerNumber) {
103103
return learnerNumber + 1 < this.learners.length ? learnerNumber + 1 : 0;
104104
},
105-
scrollToSelectedLearner(learnerNumber) {
106-
const selectedElement = this.$refs.learnerList.children[learnerNumber];
107-
if (selectedElement) {
105+
scrollToSelectedLearner(learnerNumber, selectedElement) {
106+
const el =
107+
selectedElement !== undefined
108+
? selectedElement
109+
: this.$refs.learnerList.children[learnerNumber];
110+
if (el) {
108111
const parent = this.$el.parentElement;
109-
parent.scrollTop =
110-
selectedElement.offsetHeight * (learnerNumber + 1) - parent.offsetHeight / 2;
112+
parent.scrollTop = el.offsetHeight * (learnerNumber + 1) - parent.offsetHeight / 2;
111113
}
112114
},
113115
},

kolibri/plugins/user_auth/frontend/views/SignInPage/PictureLogin/PicturePasswordOption.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
const $themeTokens = themeTokens();
8282
const $themePalette = themePalette();
8383
84-
const checkboxId = computed(() => `picture-password-option-${props.icon}`);
84+
const checkboxId = `picture-password-option-${props.icon}`;
8585
8686
const isSelected = computed(() => props.sequencePosition !== null);
8787

0 commit comments

Comments
 (0)