Break up DynamicWhiteNoise code#10648
Closed
dylanmccall wants to merge 1 commit into
Closed
Conversation
Instead of generating everything in the initializer, we will use some more specific functions. This makes it easier to create a subclass of DynamicWhiteNoise, for example to support platforms that require special libraries for file access.
Contributor
Build Artifacts
|
Member
|
I think I'd prefer to handle this a slightly different way that explicitly sets up the backend for handling different storage needs. As this doesn't seem to be pressing for anyone right now, I'm going to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of generating everything in the initializer, we will use some more specific functions. This makes it easier to create a subclass of DynamicWhiteNoise, for example to support platforms that require special libraries for file access.
Summary
This patch was really helpful to support Android file access in endlessm/kolibri-installer-android#116. Previously, we had to clone all of
kolibri_whitenoise.pyinto the Android app code, and with this change we're able to do something much more maintainable. There is still some evil involved to actually get the existing WSGI server to use our subclassedDynamicWhiteNoise, but it's much closer, and in general I think this can be classified as an innocent cleanup :)Testing checklist
PR process
Reviewer checklist
yarnandpip)