Skip to content

Scope docker hub login to push, and add attestations#14524

Merged
bjester merged 1 commit into
learningequality:developfrom
bjester:fix-container-publish
Jun 22, 2026
Merged

Scope docker hub login to push, and add attestations#14524
bjester merged 1 commit into
learningequality:developfrom
bjester:fix-container-publish

Conversation

@bjester

@bjester bjester commented Apr 2, 2026

Copy link
Copy Markdown
Member

Summary

Originally, the new container publishing workflow worked for Github but failed for Docker Hub. This was because the Docker Hub project was archived, and so after unarchiving it, publishing worked to Docker Hub.

This PR:

  • Adds attestations to both Github and Docker publishs
  • Adds explicit versions for all workflow actions
  • Retains ordering change motivated by belows outdated summary

Outdated background

The new container publishing workflow worked for Github but failed for Docker Hub:

failed to push docker.io/learningequality/kolibri:0.19.3: push access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

Looking at the documentation for the login-action, it mentions default token overriding. I don't think this will fix the issue, since it describes login tokens overriding Github's, but worth a shot.

Also adds attestations according to Github's docs

References

https://github.com/learningequality/kolibri/actions/runs/23910966630

@github-actions github-actions Bot added DEV: dev-ops Continuous integration & deployment SIZE: small labels Apr 2, 2026
@bjester bjester force-pushed the fix-container-publish branch from 880de0e to d18da55 Compare April 2, 2026 18:11
@bjester bjester requested review from DXCanas and rtibbles April 2, 2026 18:18
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

@DXCanas DXCanas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems… right? I don't know how to test this lol

And iirc, the issue with the publish had more to do with the fact that the repo was asleep; hopefully this addresses both?

@bjester

bjester commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Seems… right? I don't know how to test this lol

And iirc, the issue with the publish had more to do with the fact that the repo was asleep; hopefully this addresses both?

Yeah we fixed the publish issue so this mostly just adds attestations, which are good to have though. Will resolve the conflicts

@bjester bjester force-pushed the fix-container-publish branch from d18da55 to 8bdfafd Compare June 22, 2026 21:13
@bjester bjester force-pushed the fix-container-publish branch from 8bdfafd to 5dd259b Compare June 22, 2026 22:10
@bjester bjester merged commit 93dd810 into learningequality:develop Jun 22, 2026
61 checks passed
@bjester bjester deleted the fix-container-publish branch June 22, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEV: dev-ops Continuous integration & deployment SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants