chore(deps-dev): bump cryptography from 45.0.7 to 48.0.1 in /platforms/desktop-app#15030
chore(deps-dev): bump cryptography from 45.0.7 to 48.0.1 in /platforms/desktop-app#15030dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [cryptography](https://github.com/pyca/cryptography) from 45.0.7 to 48.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@45.0.7...48.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-version: 48.0.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
🔵 Review postedLast updated: 2026-07-18 01:23 UTC |
Build Artifacts
Smoke test screenshot |
rtibblesbot
left a comment
There was a problem hiding this comment.
PR #15030 — Dependabot bump of cryptography 45.0.7 → 48.0.1 in the desktop-app build extra.
- Semver risk: major (multi-major, 45 → 48)
- Dependency type: development / build-only —
[project.optional-dependencies].buildofkolibri-app, gated onpython_version >= '3.10'. Not imported by app code (bundled by PyInstaller via the_cffi_backendhiddenimport).grepfinds nocryptography/hazmat/x509usage inplatforms/desktop-app. - Breaking changes across the range: 48.0.0 drops Python 3.8 (requires 3.9+) and raises
ValueErroron X.509 CRLs with mismatched inner/outer signature algorithm; 47.0.0 removes OpenSSL 1.1.x (requires 3.0.0+), removes binary elliptic curves (SECT*), drops LibreSSL < 4.1, and switches unsupported-key-algorithm errors fromValueErrortoUnsupportedAlgorithm. None reach this project: build-only, not imported, Python pinned ≥ 3.10, wheels ship their own OpenSSL. - Security fixes: none called out in the range.
- CI status: failing.
REQUEST_CHANGES — the lockfile was not regenerated. This PR edits only pyproject.toml; the committed uv.lock still pins cryptography==45.0.7 for kolibri-app (uv.lock:3611, :3634). uv lock --check fails on this branch; uv lock --dry-run shows 45.0.7, 47.0.0, 49.0.0 -> 45.0.7, 47.0.0, 48.0.1, 49.0.0.
The repo enforces uv.lock via the astral-sh/uv-pre-commit uv-lock hook, so any dev running local pre-commit, or CI running uv sync --locked/--frozen, fails — or silently installs 45.0.7 instead of 48.0.1, meaning the bump does not take effect through the lock. The green Build DMG/Build EXE jobs don't catch this because make dependencies runs uv sync --extra build without --frozen (live re-resolve).
Fix: run uv lock and commit the updated uv.lock alongside the manifest change — e.g. comment @dependabot recreate, which normally regenerates both together.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Ran a dependency-update review pipeline over the version bump:
- Classified the bump by semver (patch / minor / major) and dependency type (production vs. development)
- Extracted the changelog and release notes across the version range
- Assessed compatibility with this project's usage and whether any code changes are required
- Treated CI as the primary safety net
- Scaled the review depth to the update's risk
- Chose the verdict from semver risk, changelog findings, and CI status
rtibblesbot
left a comment
There was a problem hiding this comment.
PR #15030 — Dependabot bumps cryptography 45.0.7 → 48.0.1 (multi-major, minor+major range) in the platforms/desktop-app build extra. Development/build-only dependency (bundled by PyInstaller, not imported anywhere in platforms/desktop-app), gated python_version >= '3.10'.
Same commit as the prior round (6b0c0388) — no new commits pushed. The one blocking finding is still open, so the verdict stands.
[blocking] Lockfile not regenerated for the bump
The PR edits only pyproject.toml; the committed uv.lock still resolves cryptography==45.0.7 (all cryptography-45.0.7-* wheel entries). uv lock --check fails on this branch. The repo enforces the lock via the astral-sh/uv-pre-commit uv-lock hook and any CI step running uv sync --locked/--frozen, so the manifest and lock are out of sync — and the intended bump never takes effect through the lock (45.0.7 is what actually installs). Green build jobs don't catch it because make dependencies runs uv sync --extra build without --frozen (a live re-resolve).
Fix: regenerate and commit uv.lock alongside the manifest — comment @dependabot recreate, or run uv lock and commit the result.
Compatibility
Breaking changes in the range (47.0.0 removes OpenSSL 1.1.x + SECT* curves + LibreSSL < 4.1; 48.0.0 drops Python 3.8, raises ValueError on mismatched X.509 CRL signature algorithms) don't reach this project: build-only, not imported, wheels ship their own OpenSSL, pin gated to 3.10+. No security fixes called out in the range. The bump is safe once the lockfile is regenerated.
CI
Failing. The current failure is Python unit tests on Mac OS (3.10) dying at the actions/checkout@v7.0.0 step — an infra/checkout flake, unrelated to this bump. The blocking issue remains the un-regenerated lockfile.
Prior-finding status
UNADDRESSED — platforms/desktop-app/pyproject.toml:37 — uv.lock not regenerated for the bump
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Ran a dependency-update review pipeline over the version bump:
- Classified the bump by semver (patch / minor / major) and dependency type (production vs. development)
- Extracted the changelog and release notes across the version range
- Assessed compatibility with this project's usage and whether any code changes are required
- Treated CI as the primary safety net
- Scaled the review depth to the update's risk
- Chose the verdict from semver risk, changelog findings, and CI status
Bumps cryptography from 45.0.7 to 48.0.1.
Changelog
Sourced from cryptography's changelog.
... (truncated)
Commits
de987ce48.0.1 version bump and changelog (#14996)8e03e30bump for 48.0.0 release (#14796)295e0d2Add AGENTS.md with CLAUDE.md symlink (#14794)104a2deBump BoringSSL, OpenSSL, AWS-LC in CI (#14793)67ec1e5call check_length early on AesSiv::encrypt (#14792)b2da57achangelog for mldsa/mlkem for openssl (#14791)3cf44adML-KEM OpenSSL support (#14781)2e31639ML-DSA OpenSSL support (#14773)5affe5afix rust nightly clippy (#14790)2e73ca4bump rust-openssl dep and update EcPoint::mul_generator to mul_generator2 (#1...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.