Robust solution for filtering unpublishable changes on frontend

Author: AlexVelezLl

contentcuration/contentcuration/frontend/shared/data/serverSync.js

@@ -175,7 +175,12 @@ function handleMaxRevs(response, userId) {
     maxRevs[`${MAX_REV_KEY}.${channelId}`] = channelChanges[0].server_rev;
     const lastChannelEditIndex = findLastIndex(
       channelChanges,
-      c => !c.errors && !c.user_id && c.created_by_id && c.type !== CHANGE_TYPES.PUBLISHED,
+      c =>
+        !c.errors &&
+        !c.user_id &&
+        c.created_by_id &&
+        c.type !== CHANGE_TYPES.PUBLISHED &&
+        !c.unpublishable,
     );
     const lastPublishIndex = findLastIndex(
       channelChanges,

contentcuration/contentcuration/models.py

@@ -3817,6 +3817,7 @@ def serialize(cls, change):
                 "channel_id": get_attribute(change, ["channel_id"]),
                 "user_id": get_attribute(change, ["user_id"]),
                 "created_by_id": get_attribute(change, ["created_by_id"]),
+                "unpublishable": get_attribute(change, ["unpublishable"]),
             }
         )
         return datum

contentcuration/contentcuration/viewsets/community_library_submission.py

@@ -320,6 +320,7 @@ def _add_to_community_library(self, submission):
                 categories=submission.categories,
                 country_codes=country_codes,
             ),
+            created_by_id=submission.resolved_by_id,
             # This change is not publishable and should not trigger publish-related logic
             unpublishable=True,
         )

contentcuration/contentcuration/viewsets/sync/endpoint.py

@@ -155,6 +155,7 @@ def return_changes(self, request, channel_revs):
                 "table",
                 "change_type",
                 "kwargs",
+                "unpublishable",
             )
             .order_by("server_rev")[:CHANGE_RETURN_LIMIT]
         )