Skip to content

Commit 225bd38

Browse files
committed
delete all version_notes and language for publish_next
1 parent 1720d0e commit 225bd38

7 files changed

Lines changed: 4 additions & 18 deletions

File tree

contentcuration/contentcuration/frontend/shared/data/__tests__/changes.spec.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,16 +258,14 @@ describe('Change Types', () => {
258258
key: '1',
259259
table: TABLE_NAMES.CHANNEL,
260260
use_staging_tree: false,
261-
version_notes: 'Test version notes',
262-
language: 'en',
263261
source: CLIENTID,
264262
});
265263
const rev = await change.saveChange();
266264
const persistedChange = await db[CHANGES_TABLE].get(rev);
267265
expect(persistedChange).toEqual({
268266
rev,
269267
channel_id: change.key,
270-
...pick(change, ['type', 'key', 'table', 'use_staging_tree', 'version_notes', 'language', 'source']),
268+
...pick(change, ['type', 'key', 'table', 'use_staging_tree', 'source']),
271269
});
272270
});
273271

contentcuration/contentcuration/frontend/shared/data/changes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ export class PublishedChange extends Change {
439439
}
440440

441441
export class PublishedNextChange extends Change {
442-
constructor({ use_staging_tree, version_notes, language, ...fields }) {
442+
constructor({ use_staging_tree, ...fields }) {
443443
fields.type = CHANGE_TYPES.PUBLISHED_NEXT;
444444
super(fields);
445445
if (this.table !== TABLE_NAMES.CHANNEL) {

contentcuration/contentcuration/frontend/shared/data/resources.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1237,15 +1237,11 @@ export const Channel = new CreateModelResource({
12371237
publishDraft(id, opts={}) {
12381238
const {
12391239
use_staging_tree = false,
1240-
version_notes = '',
1241-
language = currentLanguage,
12421240
} = opts;
12431241

12441242
const change = new PublishedNextChange({
12451243
key: id,
12461244
use_staging_tree,
1247-
version_notes,
1248-
language,
12491245
table: this.tableName,
12501246
source: CLIENTID,
12511247
});

contentcuration/contentcuration/frontend/shared/data/serverSync.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const ChangeTypeMapFields = {
3636
'excluded_descendants',
3737
]),
3838
[CHANGE_TYPES.PUBLISHED]: commonFields.concat(['version_notes', 'language']),
39-
[CHANGE_TYPES.PUBLISHED_NEXT]: commonFields.concat(['use_staging_tree', 'version_notes', 'language']),
39+
[CHANGE_TYPES.PUBLISHED_NEXT]: commonFields.concat(['use_staging_tree']),
4040
[CHANGE_TYPES.SYNCED]: commonFields.concat([
4141
'titles_and_descriptions',
4242
'resource_details',

contentcuration/contentcuration/tests/test_exportchannel.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -879,12 +879,10 @@ def run_publish_channel(self):
879879
publish_channel(
880880
self.admin_user.id,
881881
self.content_channel.id,
882-
version_notes="",
883882
force=False,
884883
force_exercises=False,
885884
send_email=False,
886885
progress_tracker=None,
887-
language="fr",
888886
is_draft_version=True,
889887
use_staging_tree=True,
890888
)
@@ -990,12 +988,10 @@ def run_publish_channel(self):
990988
publish_channel(
991989
self.admin_user.id,
992990
self.content_channel.id,
993-
version_notes="",
994991
force=False,
995992
force_exercises=False,
996993
send_email=False,
997994
progress_tracker=None,
998-
language="fr",
999995
is_draft_version=True,
1000996
use_staging_tree=False,
1001997
)

contentcuration/contentcuration/viewsets/channel.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -620,8 +620,6 @@ def publish_next_from_changes(self, changes):
620620
try:
621621
self.publish_next(
622622
publish["key"],
623-
# version_notes=publish.get("version_notes"),
624-
# language=publish.get("language"),
625623
use_staging_tree=publish.get("use_staging_tree", False),
626624
)
627625
except Exception as e:

contentcuration/contentcuration/viewsets/sync/utils.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,8 @@ def generate_update_descendants_event(key, mods, channel_id=None, user_id=None):
9898
return event
9999

100100

101-
def generate_publish_next_event(key, version_notes="", language=None, use_staging_tree=False):
101+
def generate_publish_next_event(key, use_staging_tree=False):
102102
event = _generate_event(key, CHANNEL, PUBLISHED_NEXT, key, None)
103-
event["version_notes"] = version_notes
104-
event["language"] = language
105103
event["use_staging_tree"] = use_staging_tree
106104
return event
107105

0 commit comments

Comments
 (0)