fix(texteditor)[markdown]: enhance falsy dimensions check for images

habibayman · habibayman · commit ea35a64634c7 · 2025-08-10T23:48:31.000+03:00
diff --git a/contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/utils/markdown.js b/contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/utils/markdown.js
@@ -43,7 +43,7 @@ export const paramsToImageMd = ({ src, alt, width, height, permanentSrc }) => {
   }
 
   const fileName = sourceToSave.split('/').pop();
-  if (width && height) {
+  if (Number.isFinite(+width) && Number.isFinite(+height)) {
     return `![${alt || ''}](${IMAGE_PLACEHOLDER}/${fileName} =${width}x${height})`;
   }
   return `![${alt || ''}](${IMAGE_PLACEHOLDER}/${fileName})`;

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ export const paramsToImageMd = ({ src, alt, width, height, permanentSrc }) => {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`const fileName = sourceToSave.split('/').pop();`
`46`		`- if (width && height) {`
	`46`	`+ if (Number.isFinite(+width) && Number.isFinite(+height)) {`
`47`	`47`	return `![${alt \|\| ''}](${IMAGE_PLACEHOLDER}/${fileName} =${width}x${height})`;
`48`	`48`	`}`
`49`	`49`	return `![${alt \|\| ''}](${IMAGE_PLACEHOLDER}/${fileName})`;